fix: address CI review feedback

Author: qartik

.github/actions/setup-llvm/action.yml

@@ -57,7 +57,11 @@ runs:
         llvm_root="${{ runner.temp }}/llvm"
         echo "LLVM_PATH=${llvm_root}" >>"$GITHUB_ENV"
         echo "${{ inputs.llvm-sys-prefix-env-var }}=${llvm_root}" >>"$GITHUB_ENV"
-        echo "LD_LIBRARY_PATH=${llvm_root}/lib:${LD_LIBRARY_PATH:-}" >>"$GITHUB_ENV"
+        if [ -n "${LD_LIBRARY_PATH:-}" ]; then
+          echo "LD_LIBRARY_PATH=${llvm_root}/lib:${LD_LIBRARY_PATH}" >>"$GITHUB_ENV"
+        else
+          echo "LD_LIBRARY_PATH=${llvm_root}/lib" >>"$GITHUB_ENV"
+        fi
 
     - name: Install LLVM (macOS)
       if: runner.os == 'macOS' && inputs.enable-macos == 'true'

.github/workflows/rust-release.yml

@@ -6,21 +6,24 @@ on:
       - 'v*.*.*'
   workflow_dispatch:
 
+env:
+  LLVM_VERSION: "21.1.8"
+  LLVM_SYS_PREFIX_ENV_VAR: "LLVM_SYS_211_PREFIX"
+
 jobs:
   publish:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v6
 
-      - name: Install LLVM
-        uses: KyleMayes/install-llvm-action@v2
+      - name: Setup LLVM
+        uses: ./.github/actions/setup-llvm
         with:
-          version: "14.0"
-          directory: ${{ runner.temp }}/llvm
-          env: true
-
-      - name: Configure LLVM
-        run: echo "LLVM_SYS_140_PREFIX=$LLVM_PATH" >> "$GITHUB_ENV"
+          llvm-version: ${{ env.LLVM_VERSION }}
+          llvm-sys-prefix-env-var: ${{ env.LLVM_SYS_PREFIX_ENV_VAR }}
+          enable-macos: "false"
+          enable-windows: "false"
+          linux-cache-key-suffix: rust-release-v1
 
       - uses: dtolnay/rust-toolchain@stable
 

examples/python_api.py

@@ -11,6 +11,7 @@
 # ///
 """Example demonstrating the qir_qis Python API."""
 
+import sys
 from pathlib import Path
 
 from rich import print as rprint
@@ -32,10 +33,17 @@
 rprint(f"Entry point attributes: {attributes}")
 
 # Compile to QIS
+if sys.platform.startswith("win"):
+    opt_level = 0
+    target = "native"
+else:
+    opt_level = 2
+    target = "aarch64"
+
 qis_bytes = qir_to_qis(
     bc_bytes,
-    opt_level=2,
-    target="aarch64",
+    opt_level=opt_level,
+    target=target,
 )
 
 # Write output

examples/rust_api.rs

@@ -16,7 +16,11 @@ fn main() -> Result<(), Box<dyn std::error::Error>> {
     println!("Required qubits: {attributes:#?}");
 
     // Compile to QIS
-    let qis_bytes = qir_to_qis(&bc_bytes, 2, "aarch64", None)?;
+    #[cfg(windows)]
+    let (opt_level, target) = (0, "native");
+    #[cfg(not(windows))]
+    let (opt_level, target) = (2, "aarch64");
+    let qis_bytes = qir_to_qis(&bc_bytes, opt_level, target, None)?;
 
     // Write output
     fs::write("output.qis.bc", qis_bytes)?;

pyproject.toml

@@ -94,7 +94,6 @@ LLVM_SYS_211_PREFIX = '/tmp/llvm'
 MACOSX_DEPLOYMENT_TARGET = "15.0"
 [tool.cibuildwheel.macos]
 before-all = [
-    'curl -sSf https://sh.rustup.rs | sh -s -- -y --profile minimal',
     'brew install llvm@21',
     'if [ "$(uname -m)" = "arm64" ]; then LLVM_PREFIX=/opt/homebrew/opt/llvm@21; else LLVM_PREFIX=/usr/local/opt/llvm@21; fi',
     'mkdir -p /tmp/llvm',