Add Aqua and fix some tests

Author: lkdvos

Project.toml

@@ -1,6 +1,6 @@
 name = "MPSKit"
 uuid = "bb1c41ca-d63c-52ed-829e-0820dda26502"
-authors = ["Maarten Van Damme", "Jutho Haegeman", "Lukas Devos", "Gertian Roose", "Markus Hauru", "Daan Maertens"]
+authors = "Lukas Devos, Maarten Van Damme and contributors"
 version = "0.12.0"
 
 [deps]
@@ -25,30 +25,38 @@ VectorInterface = "409d34a3-91d5-4945-b6ec-7529ddf182d8"
 
 [compat]
 Accessors = "0.1"
+Aqua = "0.8.9"
+BlockTensorKit = "0.1.1"
 FLoops = "0.1, 0.2"
 FastClosures = "0.3"
 FoldsThreads = "0.1"
 KrylovKit = "0.8.3"
 LinearAlgebra = "1.6"
 LoggingExtras = "~1.0"
 OptimKit = "0.3.1"
+Pkg = "1"
+Plots = "1.40"
 Preferences = "1"
 Printf = "1"
+Random = "1"
 RecipesBase = "1.1"
 TensorKit = "0.13"
 TensorKitManifolds = "0.7"
 TensorOperations = "5"
+Test = "1"
+TestExtras = "0.3"
 Transducers = "0.4"
 TupleTools = "1.6.0"
 VectorInterface = "0.2, 0.3, 0.4, 0.5"
 julia = "1.10"
 
 [extras]
+Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595"
 Pkg = "44cfe95a-1eb2-52ea-b672-e2afdf69b78f"
 Plots = "91a5bcdd-55d7-5caf-9e0b-520d859cae80"
 TensorOperations = "6aa20fa7-93e2-5fca-9bc0-fbd0db3c71a2"
 Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
 TestExtras = "5ed8adda-3752-4e41-b88a-e8b09835ee3a"
 
 [targets]
-test = ["Pkg", "Test", "TestExtras", "Plots"]
+test = ["Aqua", "Pkg", "Test", "TestExtras", "Plots"]

src/MPSKit.jl

@@ -22,8 +22,6 @@ export InfiniteMPS, FiniteMPS, WindowMPS, MPSMultiline
 export PeriodicArray, PeriodicVector, PeriodicMatrix, WindowArray
 export MPSTensor
 export QP, LeftGaugedQP, RightGaugedQP
-export leftorth,
-       rightorth, leftorth!, rightorth!, poison!, uniform_leftorth, uniform_rightorth
 export r_LL, l_LL, r_RR, l_RR, r_RL, r_LR, l_RL, l_LR # should be properties
 
 # useful utility functions?
@@ -49,8 +47,8 @@ export excitations, FiniteExcited, QuasiparticleAnsatz, ChepigaAnsatz, ChepigaAn
 export marek_gap, correlation_length, correlator
 export time_evolve, timestep!, timestep
 export TDVP, TDVP2, make_time_mpo, WI, WII, TaylorCluster
-export splitham, infinite_temperature, entanglement_spectrum, transfer_spectrum, variance
-export changebonds!, changebonds, VUMPSSvdCut, OptimalExpand, SvdCut, UnionTrunc, RandExpand
+export entanglement_spectrum, transfer_spectrum, variance
+export changebonds!, changebonds, VUMPSSvdCut, OptimalExpand, SvdCut, RandExpand
 export entropy
 export propagator, NaiveInvert, Jeckelmann, DynamicalDMRG
 export fidelity_susceptibility

src/algorithms/excitation/dmrgexcitation.jl

@@ -13,10 +13,11 @@ Variational optimization algorithm for excitations of finite Matrix Product Stat
 end
 
 function excitations(H::FiniteMPOHamiltonian, alg::FiniteExcited,
-                     states::NTuple{N,T};
+                     states::FiniteMPS...;
                      init=FiniteMPS([copy(first(states).AC[i])
                                      for i in 1:length(first(states))]),
-                     num=1) where {N,T<:FiniteMPS}
+                     num=1)
+    T = eltype(states)
     num == 0 && return (scalartype(T)[], T[])
 
     super_op = LinearCombination(tuple(H, ProjectionOperator.(states)...),

src/states/finitemps.jl

@@ -61,10 +61,10 @@ struct FiniteMPS{A<:GenericMPSTensor,B<:MPSBondTensor} <: AbstractFiniteMPS
                                                                   B<:MPSBondTensor}
         return new{A,B}(ALs, ARs, ACs, CLs)
     end
-    function FiniteMPS(ALs::Vector{Union{Missing,A}}, ARs::Vector{Union{Missing,A}},
-                       ACs::Vector{Union{Missing,A}},
-                       CLs::Vector{Union{Missing,B}}) where {A<:GenericMPSTensor,
-                                                             B<:MPSBondTensor}
+    function FiniteMPS(ALs::Vector{A}, ARs::Vector{A},
+                       ACs::Vector{A},
+                       CLs::Vector{B}) where {A<:Union{Missing,GenericMPSTensor},
+                                              B<:Union{Missing,MPSBondTensor}}
         length(ACs) == length(CLs) - 1 == length(ALs) == length(ARs) ||
             throw(DimensionMismatch("length mismatch of tensors"))
         sum(ismissing.(ACs)) + sum(ismissing.(CLs)) < length(ACs) + length(CLs) ||

test/other.jl

@@ -11,6 +11,11 @@ using MPSKit
 using TensorKit
 using TensorKit: ℙ
 using Plots
+using Aqua
+
+@testset "Aqua" begin
+    Aqua.test_all(MPSKit; ambiguities=false, piracies=false)
+end
 
 @testset "plot tests" begin
     ψ = InfiniteMPS([ℙ^2], [ℙ^5])