improve type stability

Author: lkdvos

src/algorithms/excitation/quasiparticleexcitation.jl

@@ -348,46 +348,16 @@ function effective_excitation_renormalization_energy(H::Union{InfiniteMPO,
                                                      lenvs,
                                                      renvs)
     ψ_left = ϕ.left_gs
-    E_left = map(1:length(ϕ)) do site
-        return contract_mpo_expval(ψ_left.AC[site], leftenv(lenvs, site, ψ_left),
-                                   H[site], rightenv(lenvs, site, ψ_left))
-    end
-
-    ϕ.trivial && return E_left
-
     ψ_right = ϕ.right_gs
-    E_right = map(1:length(ϕ)) do site
-        return contract_mpo_expval(ψ_right.AC[site], leftenv(renvs, site, ψ_right),
-                                   H[site], rightenv(renvs, site, ψ_right))
-    end
-
-    return (E_left .+ E_right) ./ 2
-end
-
-function effective_excitation_renormalization_energy(H, ϕ, lenvs, renvs)
-    E_left = map(1:length(ϕ)) do loc
-        AC = ϕ.left_gs.AC[loc]
-        GL = leftenv(lenvs, loc, ϕ.left_gs)
-        GR = rightenv(lenvs, loc, ϕ.left_gs)
-        return sum(keys(H[loc]); init=zero(scalartype(ϕ))) do (j, k)
-            return @plansor conj(AC[2 6; 4]) * GL[j][2 5; 3] * AC[3 7; 1] *
-                            H[loc][j, k][5 6; 7 8] *
-                            GR[k][1 8; 4]
-        end
-    end
-
-    ϕ.trivial && return E_left
-
-    E_right = map(1:length(ϕ)) do loc
-        AC = ϕ.right_gs.AC[loc]
-        GL = leftenv(renvs, loc, ϕ.right_gs)
-        GR = rightenv(renvs, loc, ϕ.right_gs)
-        return sum(keys(H[loc]); init=zero(scalartype(ϕ))) do (j, k)
-            return @plansor conj(AC[2 6; 4]) * GL[j][2 5; 3] * AC[3 7; 1] *
-                            H[loc][j, k][5 6; 7 8] *
-                            GR[k][1 8; 4]
+    E = Vector{scalartype(ϕ)}(undef, length(ϕ))
+    for i in eachindex(E)
+        E[i] = contract_mpo_expval(ψ_left.AC[i], leftenv(lenvs, i, ψ_left),
+                                   H[i], rightenv(lenvs, i, ψ_left))
+        if !ϕ.trivial
+            E[i] += contract_mpo_expval(ψ_right.AC[i], leftenv(renvs, i, ψ_right),
+                                        H[i], rightenv(renvs, i, ψ_right))
+            E[i] /= 2
         end
     end
-
-    return (E_left .+ E_right) ./ 2
+    return E
 end

src/states/quasiparticle_state.jl

@@ -63,13 +63,11 @@ function RightGaugedQP(datfun, left_gs, right_gs=left_gs;
 end
 
 #gauge dependent code
-function Base.similar(v::LeftGaugedQP, T=scalartype(v))
-    return LeftGaugedQP(v.left_gs, v.right_gs, v.VLs, map(e -> similar(e, T), v.Xs),
-                        v.momentum)
+function Base.similar(v::LeftGaugedQP, ::Type{T}=scalartype(v)) where {T<:Number}
+    return LeftGaugedQP(v.left_gs, v.right_gs, v.VLs, similar.(v.Xs, T), v.momentum)
 end
-function Base.similar(v::RightGaugedQP, T=scalartype(v))
-    return RightGaugedQP(v.left_gs, v.right_gs, map(e -> similar(e, T), v.Xs), v.VRs,
-                         v.momentum)
+function Base.similar(v::RightGaugedQP, ::Type{T}=scalartype(v)) where {T<:Number}
+    return RightGaugedQP(v.left_gs, v.right_gs, similar.(v.Xs, T), v.VRs, v.momentum)
 end
 
 Base.getindex(v::LeftGaugedQP, i::Int) = v.VLs[mod1(i, end)] * v.Xs[mod1(i, end)]