refactor operator orthogonalization to use new orths

Author: lkdvos

src/algorithms/changebonds/svdcut.jl

@@ -120,12 +120,13 @@ function changebonds!(H::FiniteMPOHamiltonian, alg::SvdCut)
     end
 
     # swipe right
+    alg_trunc = MatrixAlgebraKit.TruncatedAlgorithm(alg.alg_svd, alg.trscheme)
     for i in 1:(length(H) - 1)
-        H = left_canonicalize!(H, i; alg = alg.alg_svd, alg.trscheme)
+        H = left_canonicalize!(H, i; alg = alg_trunc)
     end
     # swipe left -- TODO: do we really need this double sweep?
     for i in length(H):-1:2
-        H = right_canonicalize!(H, i; alg = alg.alg_svd, alg.trscheme)
+        H = right_canonicalize!(H, i; alg = alg_trunc)
     end
 
     return H

src/operators/ortho.jl

@@ -1,6 +1,6 @@
 function left_canonicalize!(
         H::FiniteMPOHamiltonian, i::Int;
-        alg = Defaults.alg_qr(), trscheme::TruncationStrategy = notrunc()
+        alg::MatrixAlgebraKit.AbstractAlgorithm = Defaults.alg_qr()
     )
     1 ≤ i < length(H) || throw(ArgumentError("Bounds error in canonicalize"))
 
@@ -19,7 +19,7 @@ function left_canonicalize!(
     # QR of second column
     if size(W, 1) == 1
         tmp = transpose(C′, ((2, 1), (3,)))
-        Q, R = left_orth!(tmp; alg, trunc = trscheme)
+        Q, R = left_orth!(tmp; alg)
 
         if dim(R) == 0 # fully truncated
             V = oneunit(S) ⊞ oneunit(S)
@@ -35,7 +35,7 @@ function left_canonicalize!(
         H[i] = JordanMPOTensor(codomain(W) ← physicalspace(W) ⊗ V, Q1, W.B, Q2, W.D)
     else
         tmp = transpose(cat(insertleftunit(C′, 1), W.A; dims = 1), ((3, 1, 2), (4,)))
-        Q, R = left_orth!(tmp; alg, trunc = trscheme)
+        Q, R = left_orth!(tmp; alg)
 
         if dim(R) == 0 # fully truncated
             V = oneunit(S) ⊞ oneunit(S)
@@ -86,7 +86,7 @@ end
 
 function right_canonicalize!(
         H::FiniteMPOHamiltonian, i::Int;
-        alg = Defaults.alg_lq(), trscheme::TruncationStrategy = notrunc()
+        alg::MatrixAlgebraKit.AbstractAlgorithm = Defaults.alg_lq()
     )
     1 < i ≤ length(H) || throw(ArgumentError("Bounds error in canonicalize"))
 
@@ -105,7 +105,7 @@ function right_canonicalize!(
     # LQ of second row
     if size(W, 4) == 1
         tmp = transpose(B′, ((1,), (3, 2)))
-        R, Q = right_orth!(tmp; alg, trunc = trscheme)
+        R, Q = right_orth!(tmp; alg)
 
         if dim(R) == 0
             V = oneunit(S) ⊞ oneunit(S)
@@ -121,7 +121,7 @@ function right_canonicalize!(
         H[i] = JordanMPOTensor(V ⊗ physicalspace(W) ← domain(W), Q1, Q2, W.C, W.D)
     else
         tmp = transpose(cat(insertleftunit(B′, 4), W.A; dims = 4), ((1,), (3, 4, 2)))
-        R, Q = right_orth!(tmp; alg, trunc = trscheme)
+        R, Q = right_orth!(tmp; alg)
         if dim(R) == 0
             V = oneunit(S) ⊞ oneunit(S)
             Q1 = typeof(W.A)(undef, SumSpace{S}() ⊗ physicalspace(W) ← physicalspace(W) ⊗ SumSpace{S}())