improve type stability

Author: lkdvos

src/algorithms/excitation/quasiparticleexcitation.jl

@@ -348,20 +348,19 @@ function effective_excitation_renormalization_energy(H::Union{InfiniteMPO,
                                                      lenvs,
                                                      renvs)
     ψ_left = ϕ.left_gs
-    E_left = map(1:length(ϕ)) do site
-        return contract_mpo_expval(ψ_left.AC[site], leftenv(lenvs, site, ψ_left),
-                                   H[site], rightenv(lenvs, site, ψ_left))
-    end
-
-    ϕ.trivial && return E_left
-
     ψ_right = ϕ.right_gs
-    E_right = map(1:length(ϕ)) do site
-        return contract_mpo_expval(ψ_right.AC[site], leftenv(renvs, site, ψ_right),
-                                   H[site], rightenv(renvs, site, ψ_right))
-    end
 
-    return (E_left .+ E_right) ./ 2
+    E = Vector{scalartype(ϕ)}(undef, length(ϕ))
+    for i in 1:length(ϕ)
+        E[i] = contract_mpo_expval(ψ_left.AC[i], leftenv(lenvs, i, ψ_left),
+                                   H[i], rightenv(lenvs, i, ψ_left))
+        if !ϕ.trivial
+            E[i] += contract_mpo_expval(ψ_right.AC[i], leftenv(renvs, i, ψ_right),
+                                        H[i], rightenv(renvs, i, ψ_right))
+            E[i] /= 2
+        end
+    end
+    return E
 end
 
 function effective_excitation_renormalization_energy(H, ϕ, lenvs, renvs)