Skip to content

Conversation

@lkdvos
Copy link
Member

@lkdvos lkdvos commented Nov 13, 2024

No description provided.

@codecov
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 92.00000% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/algorithms/derivatives.jl 66.66% 2 Missing ⚠️
Files with missing lines Coverage Δ
...c/algorithms/excitation/quasiparticleexcitation.jl 81.45% <100.00%> (ø)
src/algorithms/statmech/vomps.jl 95.45% <100.00%> (ø)
src/algorithms/statmech/vumps.jl 94.00% <100.00%> (ø)
src/algorithms/timestep/timeevmpo.jl 100.00% <100.00%> (ø)
src/transfermatrix/transfer.jl 90.16% <ø> (+2.86%) ⬆️
src/algorithms/derivatives.jl 80.26% <66.66%> (ø)

@lkdvos lkdvos enabled auto-merge (squash) November 14, 2024 00:02
@lkdvos lkdvos merged commit ea5cc1c into master Nov 14, 2024
@lkdvos lkdvos deleted the ld-recursivevec branch November 14, 2024 00:17
@Gertian
Copy link
Collaborator

Gertian commented Nov 14, 2024

@lkdvos, out of interest, what used to be the motivation behind the RecursiveVec ?
And why did you get rid of it ?

@lkdvos
Copy link
Member Author

lkdvos commented Nov 14, 2024

It's just a vector of vectors, that you want to think about as the direct sum of these components, such that addition is handled recursively, scalar multiplication distributes and the inner product is the sum of the inner products. Since KrylovKit moved to supporting VectorInterface, this is actually automatically handled for arrays, so the extra layer is redundant and you can just use a vector or tuple of vectors.

@Gertian
Copy link
Collaborator

Gertian commented Nov 17, 2024

Thank you for explaining !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants