make tol a kwarg in remove_orphans!(::FiniteMPO)
#222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VictorVanthilt
changed the title
tol a kwarg in remove_orphans!(::InfiniteMPO)tol a kwarg in remove_orphans!(::FiniteMPO)
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
Member
|
Any opinions on renaming everything to |
Member
Author
|
That would hide the fact that remove_orphans (which is a rather bad name indeed) actually does more than just droptol |
Member
Author
|
Also, are you seeing all of these |
Member
|
I'll concede on the name, it's fair to say that The failing tests are actually unrelated to this, we updated the compat on TensorKitManifolds, such that now the tests are actually using TensorKit v0.14 (which they previously weren't). I'll look into fixing that hopefully this afternoon |
Member
|
Can be merged as soon as #223 is merged. |
lkdvos
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tolwas a kwarg inremove_orphans!forInfiniteMPOs and a regular argument with a default value inremove_orphans!forFiniteMPOs. This PR unifies the calling signature of the two methods.