Fix time dependent integral of TDVP and TDVP2#279
Merged
lkdvos merged 3 commits intoQuantumKitHub:masterfrom Apr 21, 2025
Merged
Fix time dependent integral of TDVP and TDVP2#279lkdvos merged 3 commits intoQuantumKitHub:masterfrom
lkdvos merged 3 commits intoQuantumKitHub:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
Contributor
Author
|
The break of documentation seems to be irrelevant to this PR. |
lkdvos
approved these changes
Apr 21, 2025
Member
lkdvos
left a comment
There was a problem hiding this comment.
Thanks a lot for the interest and the fixes, this is really greatly appreciated.
The documentation failure is indeed unrelated, should be something that is fixed once we release the new version.
I'll merge this and try to get this released asap.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for developing such a great package!
When evolving the system with a time dependent Hamiltonian, I observed
This PR will fix the above issues.