Skip to content

Fix time dependent integral of TDVP and TDVP2#279

Merged
lkdvos merged 3 commits intoQuantumKitHub:masterfrom
GiggleLiu:jg/fix-time-dependent-integral
Apr 21, 2025
Merged

Fix time dependent integral of TDVP and TDVP2#279
lkdvos merged 3 commits intoQuantumKitHub:masterfrom
GiggleLiu:jg/fix-time-dependent-integral

Conversation

@GiggleLiu
Copy link
Contributor

@GiggleLiu GiggleLiu commented Apr 20, 2025

Thank you for developing such a great package!

When evolving the system with a time dependent Hamiltonian, I observed

  1. the outcome is not accurate enough when comparing with the exact simulator.
  2. hamiltonian at a nagative time is requested.

This PR will fix the above issues.

@codecov
Copy link

codecov bot commented Apr 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
src/algorithms/timestep/tdvp.jl 90.14% <100.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@GiggleLiu
Copy link
Contributor Author

The break of documentation seems to be irrelevant to this PR.

Copy link
Member

@lkdvos lkdvos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the interest and the fixes, this is really greatly appreciated.
The documentation failure is indeed unrelated, should be something that is fixed once we release the new version.
I'll merge this and try to get this released asap.

@lkdvos lkdvos merged commit 6ca0df2 into QuantumKitHub:master Apr 21, 2025
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants