Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ see 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
lkdvos
left a comment
lkdvos
left a comment
There was a problem hiding this comment.
Just making sure I get this right, the issue effectively was that the momentum function already took the angle, while it shouldn't have?
Also, the normalization was unnecessary because the vectors already come out as normalized?
Otherwise I'm definitely happy with this change, thanks for the fix!
If you don't mind I'll rerun the example and push the changes here so the docs get updated appropriately?
Yes, basically!
Yes please :) |
|
I also realized that imposing Z2 helps to keep the degeneracies and thus the better momentum |
| " id = complex(isomorphism(ℂ^2, ℂ^2))\n", | ||
| " @tensor O[-1 -2; -3 -4] := id[-1, -3] * id[-2, -4]\n", |
There was a problem hiding this comment.
How about? id is already a function in TensorKit.jl
" I = id(ComplexF64, ℂ^2)\n",
" @tensor O[-1 -2; -3 -4] := I[-1, -3] * I[-2, -4]\n",There was a problem hiding this comment.
Oops, I didn't notice this PR is merged already; was reading it via email.
| id = complex(isomorphism(ℂ^2, ℂ^2)) | ||
| @tensor O[-1 -2; -3 -4] := id[-1, -3] * id[-2, -4] |
3 participants
The fixing of degeneracy was incorrect. I fixed the fix_degeneracies function and added some comments concerning the relation between the momentum and conformal spins.