-
Notifications
You must be signed in to change notification settings - Fork 45
Fix derivatives at the edges of finite operators #296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
... and 8 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
Currently |
|
Is this with the latest version of this branch already? Could you tell me what you are running and what the error message is? I can't seem to reproduce it for now [edit] found it, should be fixed soon |
It is fine now😄 |
|
The BlockTensorKit fix is in v0.1.9 and the version in MPSKit's Project.toml is 0.1.6 but somehow the problems have been fixed here? |
|
Given that these fixes in blocktensorkit aren't too important, I don't think it's necessary to force everyone to update. The test will automatically run on the latest version so that should do the trick |
|
Wow, didn't know the tests run on different versions than the |
|
I agree that this is not necessarily a great design choice but oh well 🤷 |
This is a bugfix for behavior described in #295, which still needs some extra tests.
In particular, we should probably test somewhere that time-evolving a groundstate yields the desired results, which is how I debugged this (as originally shown by #295 as well).
To do