Skip to content

Conversation

@leburgel
Copy link
Member

@leburgel leburgel commented Jul 3, 2025

Fixes the translation operator in the Ising CFT example. This was (I assume) accidentally changed to the identity in #290, making all the momenta identically zero. Originally noticed by noticed by Meng Cheng, and reported by @tangwei94.

While I was at it, I changed the example checksum generation to use the relative path similar to what was done in QuantumKitHub/PEPSKit.jl#227. When attempting to rebuild the Ising example I noticed that it was actually rebuilding all of them, so seemed appropriate to squeeze this in here to prevent this in the future.

@codecov
Copy link

codecov bot commented Jul 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@leburgel leburgel marked this pull request as ready for review July 3, 2025 16:39
@leburgel
Copy link
Member Author

leburgel commented Jul 3, 2025

@dartsushi, can you check that the plots here now give what you would expect?

@dartsushi
Copy link
Contributor

@dartsushi, can you check that the plots here now give what you would expect?

Perfect. Thanks for fixing those!

@leburgel leburgel changed the title [WIP] Fix translation operator in Ising CFT example Fix translation operator in Ising CFT example Jul 4, 2025
@leburgel leburgel marked this pull request as draft July 4, 2025 09:56
@leburgel leburgel marked this pull request as ready for review July 4, 2025 10:22
@leburgel
Copy link
Member Author

leburgel commented Jul 4, 2025

I added two sentences on how the scaling dimensions relate to the excitation spectrum, and I updated the MPS plot to actually use the MPS data for $L=20$ (the plot just showed the ED data again). I also chose to systematically plot the scaling dimensions versus conformal spin instead of momentum, since this removes the dependence on system size and gives the same plot for the ED and MPS data.

Should be good to go now I think.

@leburgel leburgel requested a review from lkdvos July 4, 2025 10:51
Copy link
Member

@lkdvos lkdvos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@lkdvos lkdvos merged commit e740d6a into master Jul 4, 2025
28 checks passed
@lkdvos lkdvos deleted the lb/fix_ising_example branch July 4, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants