-
Notifications
You must be signed in to change notification settings - Fork 45
Fix translation operator in Ising CFT example #304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ see 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
|
@dartsushi, can you check that the plots here now give what you would expect? |
Perfect. Thanks for fixing those! |
|
I added two sentences on how the scaling dimensions relate to the excitation spectrum, and I updated the MPS plot to actually use the MPS data for Should be good to go now I think. |
lkdvos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this!
Fixes the translation operator in the Ising CFT example. This was (I assume) accidentally changed to the identity in #290, making all the momenta identically zero. Originally noticed by noticed by Meng Cheng, and reported by @tangwei94.
While I was at it, I changed the example checksum generation to use the relative path similar to what was done in QuantumKitHub/PEPSKit.jl#227. When attempting to rebuild the Ising example I noticed that it was actually rebuilding all of them, so seemed appropriate to squeeze this in here to prevent this in the future.