MethodError for `BraidingTensor` in `rightenv`

[ZongYongyue]

I met an error when I'm running this code following the example in docs but change the Hamiltonian :

using TensorKit
using MPSKit
using MPSKitModels:FiniteChain, hubbard_model


H_u1_su2 = hubbard_model(ComplexF64, U1Irrep, SU2Irrep, FiniteChain(4); U=8.0, mu=4.0, t=1.0);
charges = fill(FermionParity(1) ⊠ U1Irrep(1) ⊠ SU2Irrep(0), 4);
H = MPSKit.add_physical_charge(H_u1_su2, charges);

ρ₀ = MPSKit.infinite_temperature_density_matrix(H)
ρ_mps = convert(FiniteMPS, ρ₀)
βs = 0.0:0.2:8.0
for i in 2:length(βs)
    global ρ_mps
    @info "Computing β = $(βs[i])"
    ρ_mps, = timestep(ρ_mps, H, βs[i - 1] / 2, -im * (βs[i] - βs[i - 1]) / 2,
                      TDVP2(; trscheme=truncdim(64)))
end

[ Info: Computing β = 0.2
ERROR: MethodError: no method matching BraidingTensor(::GradedSpace{…}, ::BlockTensorKit.SumSpace{…})
The type `BraidingTensor` exists, but no method is defined for this combination of argument types when trying to construct it.

Closest candidates are:
  BraidingTensor(::BlockTensorKit.SumSpace{S}, ::BlockTensorKit.SumSpace{S}) where S
   @ BlockTensorKit ~/.julia/packages/BlockTensorKit/1tWZQ/src/tensors/tensoroperations.jl:208
  BraidingTensor(::S, ::S) where S<:ElementarySpace
   @ TensorKit ~/.julia/packages/TensorKit/hkxhv/src/tensors/braidingtensor.jl:34
  BraidingTensor(::S, ::S, ::Bool) where S<:ElementarySpace
   @ TensorKit ~/.julia/packages/TensorKit/hkxhv/src/tensors/braidingtensor.jl:34
  ...

I found the error occurs when running * in rightenv in this line:

ca.GRs[j] = TransferMatrix(above, ca.operator[j], state.AR[j]) * ca.GRs[j + 1]

[ZongYongyue]

Currently, running the above code triggers an error in tensorcontract_type in BlockTensorKit

[ Info: Computing β = 0.2
ERROR: SpaceMismatch{String}("incompatible space types: GradedSpace{ProductSector{Tuple{FermionParity, U1Irrep, SU2Irrep}}, TensorKit.SortedVectorDict{ProductSector{Tuple{FermionParity, U1Irrep, SU2Irrep}}, Int64}} ≠ BlockTensorKit.SumSpace{GradedSpace{ProductSector{Tuple{FermionParity, U1Irrep, SU2Irrep}}, TensorKit.SortedVectorDict{ProductSector{Tuple{FermionParity, U1Irrep, SU2Irrep}}, Int64}}}")
Stacktrace:
  [1] tensorcontract_type(TC::Type, A::BlockTensorKit.BlockTensorMap{…}, ::Tuple{…}, ::Bool, B::BraidingTensor{…}, ::Tuple{…}, ::Bool, ::Tuple{…})
    @ BlockTensorKit ~/.julia/packages/BlockTensorKit/1tWZQ/src/tensors/tensoroperations.jl:72
  [2] tensoralloc_contract(TC::Type, A::BlockTensorKit.BlockTensorMap{…}, pA::Tuple{…}, conjA::Bool, B::BraidingTensor{…}, pB::Tuple{…}, conjB::Bool, pAB::Tuple{…}, istemp::Val{…}, allocator::TensorOperations.DefaultAllocator)
    @ TensorOperations ~/.julia/packages/TensorOperations/jVddt/src/implementation/allocator.jl:100
  [3] transfer_right(x::BlockTensorKit.BlockTensorMap{…}, O::MPSKit.JordanMPOTensor{…}, A::TensorMap{…}, Ab::TensorMap{…})
    @ MPSKit ~/.julia/packages/MPSKit/XpTWn/src/transfermatrix/transfer.jl:136
  [4] (::MPSKit.SingleTransferMatrix{…})(vec::BlockTensorKit.BlockTensorMap{…})
    @ MPSKit ~/.julia/packages/MPSKit/XpTWn/src/transfermatrix/transfermatrix.jl:52
  [5] *(tm::MPSKit.SingleTransferMatrix{…}, vec::BlockTensorKit.BlockTensorMap{…})
    @ MPSKit ~/.julia/packages/MPSKit/XpTWn/src/transfermatrix/transfermatrix.jl:43
  [6] rightenv(ca::MPSKit.FiniteEnvironments{…}, ind::Int64, state::FiniteMPS{…})
    @ MPSKit ~/.julia/packages/MPSKit/XpTWn/src/environments/finite_envs.jl:96

[lkdvos]

Just wanted to comment on this that I am looking into it, but somehow it seems more complicated to solve properly than I had anticipated. I will definitely try to resolve this issue asap.

[lkdvos]

Can you try again with the new version of BlockTensorKit (v0.1.11), to see if this now resolves all issues? I think it should be fixed now.

[ZongYongyue]

Great, there is no problem in BlockTensorKit! It's a boundserror in tensoradd! in TensorOperations now, could you please take a look with it?:

ERROR: BoundsError: attempt to access 0-element UnitRange{Int64} at index [1:1]
Stacktrace:
  [1] throw_boundserror(A::UnitRange{Int64}, I::Tuple{UnitRange{Int64}})
    @ Base ./essentials.jl:14
  [2] checkbounds
    @ ./abstractarray.jl:699 [inlined]
  [3] getindex
    @ ./range.jl:973 [inlined]
  [4] getindex
    @ ~/.julia/packages/BlockArrays/Ituiw/src/blockaxis.jl:411 [inlined]
  [5] unblock
    @ ~/.julia/packages/BlockArrays/Ituiw/src/views.jl:10 [inlined]
  [6] to_indices (repeats 5 times)
    @ ~/.julia/packages/BlockArrays/Ituiw/src/views.jl:33 [inlined]
  [7] to_indices
    @ ~/.julia/packages/BlockArrays/Ituiw/src/views.jl:55 [inlined]
  [8] view(::BlockArrays.BlockArray{…}, ::BlockArrays.BlockIndexRange{…}, ::BlockArrays.BlockIndexRange{…}, ::BlockArrays.BlockIndexRange{…}, ::BlockArrays.BlockIndexRange{…}, ::BlockArrays.BlockIndexRange{…})
    @ Base ./subarray.jl:213
  [9] _bview(::BlockArrays.BlockArray{…}, ::BlockArrays.BlockIndexRange{…}, ::Vararg{…})
    @ BlockArrays ~/.julia/packages/BlockArrays/Ituiw/src/blockbroadcast.jl:124
 [10] (::BlockArrays.var"#62#67"{Base.Broadcast.Broadcasted{…}, Tuple{…}})(i::Int64)
    @ BlockArrays ~/.julia/packages/BlockArrays/Ituiw/src/blockbroadcast.jl:156
 [11] ntuple
    @ ./ntuple.jl:19 [inlined]
 [12] _generic_blockbroadcast_copyto!(dest::BlockArrays.BlockedArray{…}, bc::Base.Broadcast.Broadcasted{…})
    @ BlockArrays ~/.julia/packages/BlockArrays/Ituiw/src/blockbroadcast.jl:156
 [13] copyto!
    @ ~/.julia/packages/BlockArrays/Ituiw/src/blockbroadcast.jl:163 [inlined]
 [14] _generic_blockbroadcast_copyto!(dest::BlockArrays.BlockArray{…}, bc::Base.Broadcast.Broadcasted{…})
    @ BlockArrays ~/.julia/packages/BlockArrays/Ituiw/src/blockbroadcast.jl:142
 [15] copyto!
    @ ~/.julia/packages/BlockArrays/Ituiw/src/blockbroadcast.jl:163 [inlined]
 [16] materialize!(dest::BlockArrays.BlockArray{…}, bc::Base.Broadcast.Broadcasted{…})
    @ BlockArrays ~/.julia/packages/BlockArrays/Ituiw/src/blockbroadcast.jl:131
 [17] tensoradd!(C::BlockArrays.BlockArray{…}, A::BlockArrays.BlockArray{…}, pA::Tuple{…}, conjA::Bool, α::Float64, β::VectorInterface.One, ::TensorOperations.BaseView, allocator::TensorOperations.DefaultAllocator)
    @ TensorOperations ~/.julia/packages/TensorOperations/jVddt/src/implementation/base.jl:0
 [18] tensoradd!
    @ ~/.julia/packages/TensorOperations/jVddt/src/interface.jl:42 [inlined]
 [19] planarcontract!(C::BlockTensorKit.BlockTensorMap{…}, A::BlockTensorKit.BlockTensorMap{…}, ::Tuple{…}, B::BraidingTensor{…}, ::Tuple{…}, ::Tuple{…}, α::VectorInterface.One, β::VectorInterface.Zero, backend::TensorOperations.DefaultBackend, allocator::TensorOperations.DefaultAllocator)
    @ TensorKit ~/.julia/packages/TensorKit/9IxV4/src/tensors/braidingtensor.jl:296
 [20] planarcontract!
    @ ~/.julia/packages/TensorKit/9IxV4/src/planar/planaroperations.jl:115 [inlined]
 [21] planarcontract!
    @ ~/.julia/packages/TensorKit/9IxV4/src/planar/planaroperations.jl:110 [inlined]
 [22] transfer_right(x::BlockTensorKit.BlockTensorMap{…}, O::MPSKit.JordanMPOTensor{…}, A::TensorMap{…}, Ab::TensorMap{…})

[lkdvos]

I'll leave this open for now, could you confirm that the issues are now solved?

[ZongYongyue]

It seems to be completely fine this time！Thank you very much for your efforts to fix it!