Skip to content

Conversation

@VictorVanthilt
Copy link
Member

No description provided.

@VictorVanthilt VictorVanthilt requested a review from lkdvos July 31, 2025 12:02
@codecov
Copy link

codecov bot commented Jul 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
src/algorithms/approximate/fvomps.jl 95.65% <100.00%> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@lkdvos lkdvos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@lkdvos lkdvos merged commit 6389f6f into master Jul 31, 2025
27 checks passed
@lkdvos lkdvos deleted the vv-fixsvdalg branch July 31, 2025 12:42
@VictorVanthilt
Copy link
Member Author

It caught me :(

@VictorVanthilt
Copy link
Member Author

I checked all other places where an svd is taken and they all had their parent alg's svd alg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants