Skip to content

Conversation

@lkdvos
Copy link
Member

@lkdvos lkdvos commented Aug 2, 2025

Here I'm just being slightly more careful about defining physicalspace, left_virtualspace and right_virtualspace both with a coordinate and without, which was already partially implemented for some things and not for others and kept confusing me.

@lkdvos lkdvos requested a review from VictorVanthilt August 2, 2025 17:08
@codecov
Copy link

codecov bot commented Aug 2, 2025

Codecov Report

❌ Patch coverage is 75.00000% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/operators/abstractmpo.jl 50.00% 2 Missing ⚠️
src/states/abstractmps.jl 66.66% 1 Missing ⚠️
src/states/quasiparticle_state.jl 80.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
src/states/multilinemps.jl 74.50% <100.00%> (+2.50%) ⬆️
src/states/windowmps.jl 70.00% <100.00%> (+0.86%) ⬆️
src/states/abstractmps.jl 63.63% <66.66%> (+1.73%) ⬆️
src/states/quasiparticle_state.jl 87.10% <80.00%> (+0.65%) ⬆️
src/operators/abstractmpo.jl 86.02% <50.00%> (+0.10%) ⬆️

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@VictorVanthilt VictorVanthilt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the new code isn't covered in the tests, if you care then you could also cover them in the tests. If not i'm fine with merging

@lkdvos
Copy link
Member Author

lkdvos commented Aug 2, 2025

I really love how you phrased this ❤️

@lkdvos lkdvos merged commit 0aa451f into master Aug 3, 2025
26 checks passed
@lkdvos lkdvos deleted the spaces branch August 3, 2025 16:48
@VictorVanthilt
Copy link
Member

Thanks for caring!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants