-
Notifications
You must be signed in to change notification settings - Fork 45
[Utility] Be more consistent about what space functions work for what arguments #310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
... and 4 files with indirect coverage changes 🚀 New features to boost your workflow:
|
VictorVanthilt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of the new code isn't covered in the tests, if you care then you could also cover them in the tests. If not i'm fine with merging
|
I really love how you phrased this ❤️ |
|
Thanks for caring! |
Here I'm just being slightly more careful about defining
physicalspace,left_virtualspaceandright_virtualspaceboth with a coordinate and without, which was already partially implemented for some things and not for others and kept confusing me.