Remove IDMRG logging incorrect energy #315
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the IDMRG iterations, the objective which is supposed to represent the expectation value of the Hamiltonian is completely incorrect. This is because the environment only gets recalculated with
recalculate!at the end of the sweeps, so these intermediate values are irrelevant.I chose to remove showing these values, but another option is to calculate the expectation value without passing the environments, thus recalculating at every step. I don't know how costly this step is, so I chose to do it like in
IDMRG2.