Skip to content

Conversation

@lkdvos
Copy link
Member

@lkdvos lkdvos commented Aug 28, 2025

This PR simplifies and reuses some code by using functions that already existed, and additionally refactors that to avoid using braiding tensors.
Overall this should be more friendly to multifusion things, and possibly slightly more efficient.

@codecov
Copy link

codecov bot commented Aug 28, 2025

Codecov Report

❌ Patch coverage is 88.46154% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/states/quasiparticle_state.jl 66.66% 4 Missing ⚠️
...c/algorithms/excitation/quasiparticleexcitation.jl 33.33% 2 Missing ⚠️
Files with missing lines Coverage Δ
src/algorithms/excitation/exci_transfer_system.jl 88.46% <100.00%> (+44.01%) ⬆️
src/algorithms/toolbox.jl 95.15% <100.00%> (ø)
src/environments/qp_envs.jl 93.70% <100.00%> (+0.08%) ⬆️
src/transfermatrix/transfermatrix.jl 80.00% <100.00%> (+0.51%) ⬆️
...c/algorithms/excitation/quasiparticleexcitation.jl 76.64% <33.33%> (ø)
src/states/quasiparticle_state.jl 86.25% <66.66%> (-1.25%) ⬇️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lkdvos lkdvos requested review from borisdevos and leburgel August 28, 2025 09:58
@borisdevos
Copy link
Member

borisdevos commented Aug 28, 2025

Currently I'm erroring at regularize! when I want to probe multifusion excitations which aren't the identity, which is weird because I'm guessing exci.trivial should be false there? The error is at the removeunit(v, 3) call.

Edit: I tested this with a Z2 Ising model, and I also error here for Z2Irrep(1) charges. Which means on the one hand that it's generic, and on the other hand that it's a good thing I've added these tests to #297 😄

@borisdevos
Copy link
Member

This seems to fix the issue locally. I'm also a fan of the name istopological.

@lkdvos
Copy link
Member Author

lkdvos commented Aug 29, 2025

Any chance you can migrate the charged quasiparticle tests here? It would be nice to make sure this is actually passing

@lkdvos lkdvos requested a review from borisdevos August 31, 2025 11:16
@lkdvos lkdvos enabled auto-merge (squash) August 31, 2025 11:17
@lkdvos lkdvos merged commit 8cf041f into master Sep 1, 2025
27 checks passed
@lkdvos lkdvos deleted the ld-exci-unit branch September 1, 2025 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants