-
Notifications
You must be signed in to change notification settings - Fork 45
Add support for non-sorted and overlapping indices in MPOHamiltonian constructors
#322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
e9a1011 to
7fdc344
Compare
VictorVanthilt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you give some insight as to why we need to swap and multiply neighbours?
|
The obvious case is an exchange integral (ie for quantum chemistry) T = rand(N, N) # kinetic
V = rand(N, N, N, N) # exchange
H = FiniteMPOHamiltonian(fill(V, N), (i, j) => T[i, j] * c_min() \otimes c_plus()) +
FiniteMPOHamiltonian(fill(V, N), (i, j, k, l) => V[i, j, k, l] * c_min() \otimes c_min() \otimes c_plus() \otimes c_plus()) |
|
But |
|
Does it help if you rewrite this as |
4c19ef0 to
6bd5582
Compare
No description provided.