Update objective printing for IDMRG #323
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here I try to have a middle ground solution for the IDMRG logging procedure, see also #315.
The idea here is that previously we were simply counting the "total energy" of an ever growing system, which isn't necessarily that useful. Unfortunately, actually computing the current energy of the infinite state would be somewhat painful as well since it would require computing environments at every step. Here I simply define the current energy as the difference in energy between the last iteration and the current one, which might be a slightly better measure, although it might not be variational etc.
At some point it might be worth it to think about "normalizing" the DMRG environments to subtract these linearly growing contributions, but I think this is a good temporary middle ground.