-
Notifications
You must be signed in to change notification settings - Fork 45
Refactor of IDMRG with IterativeSolver
#348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ing code between IDMRG and IDMRG2
|
Your PR no longer requires formatting changes. Thank you for your contribution! |
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 17 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
@lkdvos: I have implemented the points we discussed today. it.state = IDMRGState(mps, state.operator, envs, state.iter + 1, ϵ, T(E_new))I am not sure, which way I prefer. |
|
PS: The one-line change in |
lkdvos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks great, thank you!
In this PR, I refactor
IDMRGto follow theIterativeSolverinterface (asVUMPS).This allows to share more code between
IDMRGandIDMRG2and also simplifies overloading some parts of the algorithm for e.g. differentMPOtypes.