similar(InfiniteMPOHamiltonian,::Type) is not an InfiniteMPOHamiltonian

[AFeuerpfeil]

When calling e.g. similar(H,Int) on an InfiniteMPOHamiltonian, the output is not a InfiniteMPOHamiltonian.

One example to reproduce this issue is

symmetry = TensorKit.SU2Irrep
spin = 1
J = 1
chain = InfiniteChain(1)
H = heisenberg_XXX(symmetry, chain; J, spin);
similar(H,Int) isa InfiniteMPOHamiltonian
typeof(similar(H,Int))

with the output

MPOHamiltonian{MPSKit.JordanMPOTensor{Int64, GradedSpace{SU2Irrep, TensorKit.SortedVectorDict{SU2Irrep, Int64}}, Union{BraidingTensor{Int64, GradedSpace{SU2Irrep, TensorKit.SortedVectorDict{SU2Irrep, Int64}}}, TensorMap{Int64, GradedSpace{SU2Irrep, TensorKit.SortedVectorDict{SU2Irrep, Int64}}, 2, 2, Vector{Int64}}}, TensorMap{Int64, GradedSpace{SU2Irrep, TensorKit.SortedVectorDict{SU2Irrep, Int64}}, 2, 1, Vector{Int64}}, TensorMap{Int64, GradedSpace{SU2Irrep, TensorKit.SortedVectorDict{SU2Irrep, Int64}}, 1, 2, Vector{Int64}}, TensorMap{Int64, GradedSpace{SU2Irrep, TensorKit.SortedVectorDict{SU2Irrep, Int64}}, 1, 1, Vector{Int64}}}, PeriodicVector{MPSKit.JordanMPOTensor{Int64, GradedSpace{SU2Irrep, TensorKit.SortedVectorDict{SU2Irrep, Int64}}, Union{BraidingTensor{Int64, GradedSpace{SU2Irrep, TensorKit.SortedVectorDict{SU2Irrep, Int64}}}, TensorMap{Int64, GradedSpace{SU2Irrep, TensorKit.SortedVectorDict{SU2Irrep, Int64}}, 2, 2, Vector{Int64}}}, TensorMap{Int64, GradedSpace{SU2Irrep, TensorKit.SortedVectorDict{SU2Irrep, Int64}}, 2, 1, Vector{Int64}}, TensorMap{Int64, GradedSpace{SU2Irrep, TensorKit.SortedVectorDict{SU2Irrep, Int64}}, 1, 2, Vector{Int64}}, TensorMap{Int64, GradedSpace{SU2Irrep, TensorKit.SortedVectorDict{SU2Irrep, Int64}}, 1, 1, Vector{Int64}}}, Vector{MPSKit.JordanMPOTensor{Int64, GradedSpace{SU2Irrep, TensorKit.SortedVectorDict{SU2Irrep, Int64}}, Union{BraidingTensor{Int64, GradedSpace{SU2Irrep, TensorKit.SortedVectorDict{SU2Irrep, Int64}}}, TensorMap{Int64, GradedSpace{SU2Irrep, TensorKit.SortedVectorDict{SU2Irrep, Int64}}, 2, 2, Vector{Int64}}}, TensorMap{Int64, GradedSpace{SU2Irrep, TensorKit.SortedVectorDict{SU2Irrep, Int64}}, 2, 1, Vector{Int64}}, TensorMap{Int64, GradedSpace{SU2Irrep, TensorKit.SortedVectorDict{SU2Irrep, Int64}}, 1, 2, Vector{Int64}}, TensorMap{Int64, GradedSpace{SU2Irrep, TensorKit.SortedVectorDict{SU2Irrep, Int64}}, 1, 1, Vector{Int64}}}}}}

[borisdevos]

I can't seem to reproduce this. I'm on TensorKit v0.15.3, MPSKit v0.13.8 and MPSKitModels v0.4.4.

julia> typeof(H)
InfiniteMPOHamiltonian{JordanMPOTensor{ComplexF64, GradedSpace{SU2Irrep, SortedVectorDict{SU2Irrep, Int64}}, Union{BraidingTensor{ComplexF64, GradedSpace{SU2Irrep, SortedVectorDict{SU2Irrep, Int64}}}, TensorMap{ComplexF64, GradedSpace{SU2Irrep, SortedVectorDict{SU2Irrep, Int64}}, 2, 2, Vector{ComplexF64}}}, TensorMap{ComplexF64, GradedSpace{SU2Irrep, SortedVectorDict{SU2Irrep, Int64}}, 2, 1, Vector{ComplexF64}}, TensorMap{ComplexF64, GradedSpace{SU2Irrep, SortedVectorDict{SU2Irrep, Int64}}, 1, 2, Vector{ComplexF64}}, TensorMap{ComplexF64, GradedSpace{SU2Irrep, SortedVectorDict{SU2Irrep, Int64}}, 1, 1, Vector{ComplexF64}}}}

julia> typeof(similar(H, Int))
InfiniteMPOHamiltonian{JordanMPOTensor{Int64, GradedSpace{SU2Irrep, SortedVectorDict{SU2Irrep, Int64}}, Union{BraidingTensor{Int64, GradedSpace{SU2Irrep, SortedVectorDict{SU2Irrep, Int64}}}, TensorMap{Int64, GradedSpace{SU2Irrep, SortedVectorDict{SU2Irrep, Int64}}, 2, 2, Vector{Int64}}}, TensorMap{Int64, GradedSpace{SU2Irrep, SortedVectorDict{SU2Irrep, Int64}}, 2, 1, Vector{Int64}}, TensorMap{Int64, GradedSpace{SU2Irrep, SortedVectorDict{SU2Irrep, Int64}}, 1, 2, Vector{Int64}}, TensorMap{Int64, GradedSpace{SU2Irrep, SortedVectorDict{SU2Irrep, Int64}}, 1, 1, Vector{Int64}}}}

julia> typeof(H) == typeof(similar(H, ComplexF64))
true

[AFeuerpfeil]

Sorry, I still had a fork of MPSKit.jl loaded.
This was an issue with some changes I made to PeriodicArray.