Skip to content

Conversation

@VicVanderLinden
Copy link
Contributor

Updating the example of windowMPS so it can run in latest version

@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2025

Your PR no longer requires formatting changes. Thank you for your contribution!

@lkdvos
Copy link
Member

lkdvos commented Nov 10, 2025

Thanks for helping out, I greatly appreciate this!
It seems like there are still some small formatting changes required, would you mind also changing that?

In the future, it would be nice to promote this to a full example that we can actually include in the documentation. If this is something you are interested in, I'm definitely happy to help you get that set up.

@VicVanderLinden
Copy link
Contributor Author

Hi, thanks! I am still getting the hang of Github but I definitely would be open to doing something like that. Maybe an entire example showing the WindowMPS for an improved version of https://arxiv.org/abs/1907.02474 would be nice?

@codecov
Copy link

codecov bot commented Nov 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
see 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lkdvos
Copy link
Member

lkdvos commented Nov 10, 2025

That would definitely be great! If you have the time to start putting together a script, in whatever form you like, it is then straightforward to incorporate it in the docs. I will already merge this once the tests pass, as I think it is already a great improvement, but I would definitely love to improve on that.

@lkdvos lkdvos enabled auto-merge (squash) November 10, 2025 20:02
@lkdvos lkdvos merged commit 8d378c6 into QuantumKitHub:main Nov 10, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants