-
Notifications
You must be signed in to change notification settings - Fork 18
Add t-J model #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add t-J model #38
Conversation
Codecov ReportAttention: Patch coverage is
|
lkdvos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, thanks a lot!
Some minor remarks I would like to change before merging:
- Could you try to revert the formatting changes you made that are unrelated to the changes of this PR? I'm not necessarily attached to the formatting style, but it's a bit nicer to keep that in separate commits/PRs
- Can you maybe expand
sfintoslavefermion? I think this is slightly clearer. - Similarly, I think
e_plusmin_updownis slightly clearer thane_plusmin_ud, but this is less of a strong opinion. - In docstrings, there is typically a distinction between code in single backticks, and math in double backticks. I don't mind too much if it is LaTeX or unicode, but I would avoid having LaTeX curly braces in single backticks, as that gets parsed/highlighted differently
|
@lkdvos I have made the requested changes; please see if everything is OK now |
lkdvos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed some small formatting things, will merge once tests finish. Thanks!
Currently only Abelian symmetries are implemented:
TrivialandU1IrrepTrivialandU1IrrepThere is a
sf::Boolslave_fermion::Booloption that switches to the slave-fermion basis of the physical space, in which the holons are fermionic while spinons are bosonic.