Skip to content

Conversation

@Yue-Zhengyuan
Copy link
Member

@Yue-Zhengyuan Yue-Zhengyuan commented Nov 30, 2024

Currently only Abelian symmetries are implemented:

  • Particle: Trivial and U1Irrep
  • Spin: Trivial and U1Irrep

There is a sf::Bool slave_fermion::Bool option that switches to the slave-fermion basis of the physical space, in which the holons are fermionic while spinons are bosonic.

@Yue-Zhengyuan Yue-Zhengyuan marked this pull request as ready for review November 30, 2024 08:51
@Yue-Zhengyuan Yue-Zhengyuan marked this pull request as draft November 30, 2024 12:19
@Yue-Zhengyuan Yue-Zhengyuan marked this pull request as ready for review December 1, 2024 02:29
@codecov
Copy link

codecov bot commented Dec 1, 2024

Codecov Report

Attention: Patch coverage is 77.46914% with 73 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/operators/tjoperators.jl 80.96% 59 Missing ⚠️
src/models/hamiltonians.jl 0.00% 14 Missing ⚠️
Files with missing lines Coverage Δ
src/operators/hubbardoperators.jl 69.72% <ø> (ø)
src/models/hamiltonians.jl 19.35% <0.00%> (-2.47%) ⬇️
src/operators/tjoperators.jl 80.96% <80.96%> (ø)

Copy link
Member

@lkdvos lkdvos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, thanks a lot!

Some minor remarks I would like to change before merging:

  • Could you try to revert the formatting changes you made that are unrelated to the changes of this PR? I'm not necessarily attached to the formatting style, but it's a bit nicer to keep that in separate commits/PRs
  • Can you maybe expand sf into slavefermion? I think this is slightly clearer.
  • Similarly, I think e_plusmin_updown is slightly clearer than e_plusmin_ud, but this is less of a strong opinion.
  • In docstrings, there is typically a distinction between code in single backticks, and math in double backticks. I don't mind too much if it is LaTeX or unicode, but I would avoid having LaTeX curly braces in single backticks, as that gets parsed/highlighted differently

@Yue-Zhengyuan
Copy link
Member Author

@lkdvos I have made the requested changes; please see if everything is OK now

@Yue-Zhengyuan Yue-Zhengyuan requested a review from lkdvos December 1, 2024 14:12
Copy link
Member

@lkdvos lkdvos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed some small formatting things, will merge once tests finish. Thanks!

@lkdvos lkdvos merged commit de22235 into QuantumKitHub:master Dec 2, 2024
9 checks passed
@Yue-Zhengyuan Yue-Zhengyuan deleted the master branch December 3, 2024 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants