-
Notifications
You must be signed in to change notification settings - Fork 18
Add sigma t-J model #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
🚀 New features to boost your workflow:
|
|
It might be more convenient to simply give this function a different name, instead of trying to pass everything through the same functions and having to control it with keyword arguments? |
|
Personally I think the difference from the usual t-J model is quite minor (although the physics changes a lot), so I don't quite want to make a new function to construct the Hamiltonian... |
|
Maybe, but if you take that argument further, more or less all models are the same, all spin models are very similar, all fermionic models are, all spinfull fermionic models are, ... My main problem with it however is that |
|
Oh I did overlook the different symmetry between the two models, since I hardly use the SU(2) symmetry. Now I agree that these two models should be separated. Thanks for pointing this out! |
lkdvos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for the delay, this slipped my attention.
Looks good to go for me, is there any chance you have a benchmark result for this model? Perhaps a groundstate energy for some easy/somewhat trivial parameterset? It would be nice to be able to have a test for this
|
Honestly I don't have a benchmark result. The σ t-J model is a somewhat artificial construction. Now I think it's better to leave this un-standard model out of a public package until its physical significance is widely recognized and a good benchmark result is available. |
This PR adds the so-called "sigma t-J model", which changes the hopping term of the t-J model to