-
Notifications
You must be signed in to change notification settings - Fork 18
Export FiniteCylinder and FiniteStrip #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Lukas Devos <[email protected]>
Codecov ReportAttention: Patch coverage is
🚀 New features to boost your workflow:
|
lkdvos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Strips are just square lattices with open boundary conditions where the Cylinder would have periodic boundary conditions.
For the finite case, I admit that this might not be the best name, it seemed to make sense to me in the infinite case because you have infinite repeating in one direction and finite open boundary conditions in the other. I'm open to suggestions here.
The helix represents a twisted boundary condition object, so for a circumference of 3 you'd get: (4, 1) == (1, 2). You can think about this as taking a square grid on a piece of paper, rolling it into a cylinder, and then instead of keeping it straight you slide it over by one column.
|
@lkdvos Am i correct when I say that: |
|
I think the idea was that these have finite length, while the infinite versions have infinite length, and all of them have finite circumference |
|
I added tests for the FiniteStrip and exported it. I'm going to leave FiniteHelix as is for now. |
This PR exports the existing FiniteCylinder code.
I need some help with the tests for FiniteHelix and FiniteStrip as I do not really know what they represent exactly.
I updated the CI for JuliaFormatter as the new version (v2) is giving me and a lot of others some issues (see: domluna/JuliaFormatter.jl#907, domluna/JuliaFormatter#912, ...)