Skip to content

Conversation

@VictorVanthilt
Copy link
Member

This PR exports the existing FiniteCylinder code.
I need some help with the tests for FiniteHelix and FiniteStrip as I do not really know what they represent exactly.

I updated the CI for JuliaFormatter as the new version (v2) is giving me and a lot of others some issues (see: domluna/JuliaFormatter.jl#907, domluna/JuliaFormatter#912, ...)

@codecov
Copy link

codecov bot commented Apr 11, 2025

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/lattices/squarelattice.jl 85.71% 1 Missing ⚠️
Files with missing lines Coverage Δ
src/MPSKitModels.jl 100.00% <ø> (ø)
src/lattices/squarelattice.jl 69.72% <85.71%> (+23.05%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@lkdvos lkdvos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Strips are just square lattices with open boundary conditions where the Cylinder would have periodic boundary conditions.
For the finite case, I admit that this might not be the best name, it seemed to make sense to me in the infinite case because you have infinite repeating in one direction and finite open boundary conditions in the other. I'm open to suggestions here.

The helix represents a twisted boundary condition object, so for a circumference of 3 you'd get: (4, 1) == (1, 2). You can think about this as taking a square grid on a piece of paper, rolling it into a cylinder, and then instead of keeping it straight you slide it over by one column.

@VictorVanthilt
Copy link
Member Author

@lkdvos Am i correct when I say that:
A FiniteCylinder or a FiniteHelix has a finite circumference but an infinite length?

@lkdvos
Copy link
Member

lkdvos commented Apr 12, 2025

I think the idea was that these have finite length, while the infinite versions have infinite length, and all of them have finite circumference

@VictorVanthilt VictorVanthilt changed the title Export FiniteCylinder Export FiniteCylinder and FiniteStrip Apr 14, 2025
@VictorVanthilt
Copy link
Member Author

I added tests for the FiniteStrip and exported it. I'm going to leave FiniteHelix as is for now.

@VictorVanthilt VictorVanthilt requested a review from lkdvos April 14, 2025 08:51
@lkdvos lkdvos merged commit 1dc9592 into master Apr 14, 2025
9 checks passed
@VictorVanthilt VictorVanthilt deleted the vv-FiniteExport branch April 14, 2025 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants