Use existing implementation for column permute

Author: kshyatt

ext/MatrixAlgebraKitAMDGPUExt/MatrixAlgebraKitAMDGPUExt.jl

@@ -167,11 +167,4 @@ function MatrixAlgebraKit._mul_herm!(C::StridedROCMatrix{T}, A::StridedROCMatrix
     return C
 end
 
-function MatrixAlgebraKit.permute_V_cols!(V, I::ROCVector{Int})
-    I_ixs = ROCArray(collect(1:size(V, 1)))
-    c_ixs = map(CartesianIndex, I, I_ixs)
-    V[c_ixs] .= one(eltype(V))
-    return V
-end
-
 end

ext/MatrixAlgebraKitCUDAExt/MatrixAlgebraKitCUDAExt.jl

@@ -191,11 +191,4 @@ function MatrixAlgebraKit._mul_herm!(C::StridedCuMatrix{T}, A::StridedCuMatrix{T
     return C
 end
 
-function MatrixAlgebraKit.permute_V_cols!(V, I::CuVector{Int})
-    I_ixs = CuArray(collect(1:size(V, 1)))
-    c_ixs = map(CartesianIndex, I, I_ixs)
-    V[c_ixs] .= one(eltype(V))
-    return V
-end
-
 end

src/implementations/eigh.jl

@@ -141,8 +141,6 @@ function eigh_trunc_no_error!(A, DV, alg::TruncatedAlgorithm)
     return DVtrunc
 end
 
-permute_V_cols!(V, I::Vector{Int}) = Base.permutecols!!(V, I)
-
 # Diagonal logic
 # --------------
 function eigh_full!(A::Diagonal, DV, alg::DiagonalAlgorithm)
@@ -155,7 +153,9 @@ function eigh_full!(A::Diagonal, DV, alg::DiagonalAlgorithm)
         diagview(D) .= real.(diagview(A))[I]
     end
     zero!(V)
-    V = permute_V_cols!(V, I)
+    n = size(A, 1)
+    I .+= (0:(n - 1)) .* n
+    V[I] .= Ref(one(eltype(V)))
     return D, V
 end