Skip to content

Commit 1e15667

Browse files
kshyattKatharine Hyatt
andauthored
Loosen types on polar copy_input to work with TensorMap (#45)
Co-authored-by: Katharine Hyatt <katharine.s.hyatt@gmail.com>
1 parent 1220c32 commit 1e15667

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

src/implementations/polar.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# Inputs
22
# ------
3-
copy_input(::typeof(left_polar), A::AbstractMatrix) = copy_input(svd_full, A)
4-
copy_input(::typeof(right_polar), A::AbstractMatrix) = copy_input(svd_full, A)
3+
copy_input(::typeof(left_polar), A) = copy_input(svd_full, A)
4+
copy_input(::typeof(right_polar), A) = copy_input(svd_full, A)
55

66
function check_input(::typeof(left_polar!), A::AbstractMatrix, WP)
77
m, n = size(A)

src/implementations/svd.jl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
# Inputs
22
# ------
3-
function copy_input(::typeof(svd_full), A::AbstractMatrix)
3+
function copy_input(::typeof(svd_full), A)
44
return copy!(similar(A, float(eltype(A))), A)
55
end
6-
copy_input(::typeof(svd_compact), A::AbstractMatrix) = copy_input(svd_full, A)
7-
copy_input(::typeof(svd_vals), A::AbstractMatrix) = copy_input(svd_full, A)
6+
copy_input(::typeof(svd_compact), A) = copy_input(svd_full, A)
7+
copy_input(::typeof(svd_vals), A) = copy_input(svd_full, A)
88
copy_input(::typeof(svd_trunc), A) = copy_input(svd_compact, A)
99

1010
# TODO: many of these checks are happening again in the LAPACK routines

0 commit comments

Comments
 (0)