Skip to content

Commit 21d225e

Browse files
committed
reduce unnecessary warnings
1 parent bc6fa45 commit 21d225e

File tree

5 files changed

+12
-12
lines changed

5 files changed

+12
-12
lines changed

src/pullbacks/eig.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ function eig_pullback!(
4343
4444
mask = abs.(transpose(D) .- D) .< degeneracy_atol
4545
Δgauge = norm(view(VᴴΔV, mask), Inf)
46-
Δgauge < gauge_atol ||
46+
Δgauge gauge_atol ||
4747
@warn "`eig` cotangents sensitive to gauge choice: (|Δgauge| = $Δgauge)"
4848
4949
VᴴΔV .*= conj.(inv_safe.(transpose(D) .- D, degeneracy_atol))
@@ -121,7 +121,7 @@ function eig_trunc_pullback!(
121121
VᴴΔV = V' * ΔV
122122
mask = abs.(transpose(D) .- D) .< degeneracy_atol
123123
Δgauge = norm(view(VᴴΔV, mask), Inf)
124-
Δgauge < gauge_atol ||
124+
Δgauge gauge_atol ||
125125
@warn "`eig` cotangents sensitive to gauge choice: (|Δgauge| = $Δgauge)"
126126
127127
ΔVperp = ΔV - V * inv(G) * VᴴΔV

src/pullbacks/eigh.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ function eigh_pullback!(
4444
4545
mask = abs.(D' .- D) .< degeneracy_atol
4646
Δgauge = norm(view(aVᴴΔV, mask))
47-
Δgauge < gauge_atol ||
47+
Δgauge gauge_atol ||
4848
@warn "`eigh` cotangents sensitive to gauge choice: (|Δgauge| = $Δgauge)"
4949

5050
aVᴴΔV .*= inv_safe.(D' .- D, degeneracy_atol)
@@ -112,7 +112,7 @@ function eigh_trunc_pullback!(
112112
113113
mask = abs.(D' .- D) .< degeneracy_atol
114114
Δgauge = norm(view(aVᴴΔV, mask))
115-
Δgauge < gauge_atol ||
115+
Δgauge gauge_atol ||
116116
@warn "`eigh` cotangents sensitive to gauge choice: (|Δgauge| = $Δgauge)"
117117
118118
aVᴴΔV .*= inv_safe.(D' .- D, degeneracy_atol)

src/pullbacks/lq.jl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ function lq_pullback!(
5050
ΔL22 = view(ΔL, (p + 1):m, (p + 1):minmn)
5151
Δgauge = max(Δgauge, norm(ΔL22, Inf))
5252
end
53-
Δgauge < gauge_atol ||
53+
Δgauge gauge_atol ||
5454
@warn "`lq` cotangents sensitive to gauge choice: (|Δgauge| = $Δgauge)"
5555
end
5656

@@ -70,7 +70,7 @@ function lq_pullback!(
7070
# Q2' * ΔQ2 as a gauge dependent quantity.
7171
ΔQ2Q1ᴴ = ΔQ2 * Q1'
7272
Δgauge = norm(mul!(copy(ΔQ2), ΔQ2Q1ᴴ, Q1, -1, 1), Inf)
73-
Δgauge < gauge_atol ||
73+
Δgauge gauge_atol ||
7474
@warn "`lq` cotangents sensitive to gauge choice: (|Δgauge| = $Δgauge)"
7575
ΔQ̃ = mul!(ΔQ̃, ΔQ2Q1ᴴ', Q2, -1, 1)
7676
end
@@ -120,7 +120,7 @@ function lq_null_pullback!(
120120
if !iszerotangent(ΔNᴴ) && size(Nᴴ, 1) > 0
121121
aNᴴΔN = project_antihermitian!(Nᴴ * ΔNᴴ')
122122
Δgauge = norm(aNᴴΔN)
123-
Δgauge < gauge_atol ||
123+
Δgauge gauge_atol ||
124124
@warn "`lq_null` cotangent sensitive to gauge choice: (|Δgauge| = $Δgauge)"
125125
L, Q = lq_compact(A; positive = true) # should we be able to provide algorithm here?
126126
X = ldiv!(LowerTriangular(L)', Q * ΔNᴴ')

src/pullbacks/qr.jl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ function qr_pullback!(
5151
ΔR22 = view(ΔR, (p + 1):minmn, (p + 1):n)
5252
Δgauge = max(Δgauge, norm(ΔR22, Inf))
5353
end
54-
Δgauge < gauge_atol ||
54+
Δgauge gauge_atol ||
5555
@warn "`qr` cotangents sensitive to gauge choice: (|Δgauge| = $Δgauge)"
5656
end
5757

@@ -70,7 +70,7 @@ function qr_pullback!(
7070
# Q2' * ΔQ2 as a gauge dependent quantity.
7171
Q1dΔQ2 = Q1' * ΔQ2
7272
Δgauge = norm(mul!(copy(ΔQ2), Q1, Q1dΔQ2, -1, 1), Inf)
73-
Δgauge < gauge_atol ||
73+
Δgauge gauge_atol ||
7474
@warn "`qr` cotangents sensitive to gauge choice: (|Δgauge| = $Δgauge)"
7575
ΔQ̃ = mul!(ΔQ̃, Q2, Q1dΔQ2', -1, 1)
7676
end
@@ -120,7 +120,7 @@ function qr_null_pullback!(
120120
if !iszerotangent(ΔN) && size(N, 2) > 0
121121
aNᴴΔN = project_antihermitian!(N' * ΔN)
122122
Δgauge = norm(aNᴴΔN)
123-
Δgauge < gauge_atol ||
123+
Δgauge gauge_atol ||
124124
@warn "`qr_null` cotangent sensitive to gauge choice: (|Δgauge| = $Δgauge)"
125125
126126
Q, R = qr_compact(A; positive = true)

src/pullbacks/svd.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ function svd_pullback!(
7272
# check whether cotangents arise from gauge-invariance objective function
7373
mask = abs.(Sr' .- Sr) .< degeneracy_atol
7474
Δgauge = norm(view(aUΔU, mask) + view(aVΔV, mask), Inf)
75-
Δgauge < gauge_atol ||
75+
Δgauge gauge_atol ||
7676
@warn "`svd` cotangents sensitive to gauge choice: (|Δgauge| = $Δgauge)"
7777

7878
UdΔAV = (aUΔU .+ aVΔV) .* inv_safe.(Sr' .- Sr, degeneracy_atol) .+
@@ -160,7 +160,7 @@ function svd_trunc_pullback!(
160160
# check whether cotangents arise from gauge-invariance objective function
161161
mask = abs.(S' .- S) .< degeneracy_atol
162162
Δgauge = norm(view(aUΔU, mask) + view(aVΔV, mask), Inf)
163-
Δgauge < gauge_atol ||
163+
Δgauge gauge_atol ||
164164
@warn "`svd` cotangents sensitive to gauge choice: (|Δgauge| = $Δgauge)"
165165

166166
UdΔAV = (aUΔU .+ aVΔV) .* inv_safe.(S' .- S, degeneracy_atol) .+

0 commit comments

Comments
 (0)