Use testsuite for SVD tests (#137)

* Use testsuite for SVD tests

* Don't test Diagonal + GPU with trunc

* Fix AMD algs

* Update test/testsuite/svd.jl

Co-authored-by: Lukas Devos <[email protected]>

* Update test/testsuite/svd.jl

Co-authored-by: Lukas Devos <[email protected]>

* Update test/testsuite/svd.jl

Co-authored-by: Lukas Devos <[email protected]>

* Update test/testsuite/svd.jl

Co-authored-by: Lukas Devos <[email protected]>

* Update test/testsuite/svd.jl

Co-authored-by: Lukas Devos <[email protected]>

* Update test/testsuite/svd.jl

Co-authored-by: Jutho <[email protected]>

* Restore svd_trunc for GLA

* Instantiate unitary

---------

Co-authored-by: Lukas Devos <[email protected]>
Co-authored-by: Jutho <[email protected]>

Author: 3 people

src/implementations/svd.jl

@@ -152,6 +152,14 @@ end
 function svd_compact!(A::AbstractMatrix, USVᴴ, alg::LAPACK_SVDAlgorithm)
     check_input(svd_compact!, A, USVᴴ, alg)
     U, S, Vᴴ = USVᴴ
+    m, n = size(A)
+    minmn = min(m, n)
+    if minmn == 0
+        one!(U)
+        zero!(S)
+        one!(Vᴴ)
+        return USVᴴ
+    end
 
     do_gauge_fix = get(alg.kwargs, :fixgauge, default_fixgauge())::Bool
     alg_kwargs = Base.structdiff(alg.kwargs, NamedTuple{(:fixgauge,)})
@@ -181,6 +189,12 @@ end
 
 function svd_vals!(A::AbstractMatrix, S, alg::LAPACK_SVDAlgorithm)
     check_input(svd_vals!, A, S, alg)
+    m, n = size(A)
+    minmn = min(m, n)
+    if minmn == 0
+        zero!(S)
+        return S
+    end
     U, Vᴴ = similar(A, (0, 0)), similar(A, (0, 0))
 
     alg_kwargs = Base.structdiff(alg.kwargs, NamedTuple{(:fixgauge,)})
@@ -256,6 +270,12 @@ function svd_compact!(A, USVᴴ, alg::DiagonalAlgorithm)
 end
 function svd_vals!(A::AbstractMatrix, S, alg::DiagonalAlgorithm)
     check_input(svd_vals!, A, S, alg)
+    m, n = size(A)
+    minmn = min(m, n)
+    if minmn == 0
+        zero!(S)
+        return S
+    end
     Ad = diagview(A)
     S .= abs.(Ad)
     sort!(S; rev = true)
@@ -407,6 +427,14 @@ end
 function svd_compact!(A::AbstractMatrix, USVᴴ, alg::GPU_SVDAlgorithm)
     check_input(svd_compact!, A, USVᴴ, alg)
     U, S, Vᴴ = USVᴴ
+    m, n = size(A)
+    minmn = min(m, n)
+    if minmn == 0
+        one!(U)
+        zero!(S)
+        one!(Vᴴ)
+        return USVᴴ
+    end
 
     do_gauge_fix = get(alg.kwargs, :fixgauge, default_fixgauge())::Bool
     alg_kwargs = Base.structdiff(alg.kwargs, NamedTuple{(:fixgauge,)})
@@ -431,6 +459,12 @@ _largest(x, y) = abs(x) < abs(y) ? y : x
 
 function svd_vals!(A::AbstractMatrix, S, alg::GPU_SVDAlgorithm)
     check_input(svd_vals!, A, S, alg)
+    m, n = size(A)
+    minmn = min(m, n)
+    if minmn == 0
+        zero!(S)
+        return S
+    end
     U, Vᴴ = similar(A, (0, 0)), similar(A, (0, 0))
 
     alg_kwargs = Base.structdiff(alg.kwargs, NamedTuple{(:fixgauge,)})