Turn off non-supported Schur tests and add polar for AMD

Author: kshyatt

test/amd/polar.jl

@@ -0,0 +1,63 @@
+using MatrixAlgebraKit
+using Test
+using TestExtras
+using StableRNGs
+using LinearAlgebra: LinearAlgebra, I, isposdef
+using MatrixAlgebraKit: PolarViaSVD
+using AMDGPU
+
+@testset "left_polar! for T = $T" for T in (Float32, Float64, ComplexF32, ComplexF64)
+    rng = StableRNG(123)
+    m = 54
+    @testset "size ($m, $n)" for n in (37, m)
+        k = min(m, n)
+        svd_algs = (rocSOLVER_QRIteration(), rocSOLVER_Jacobi())
+        @testset "algorithm $svd_alg" for svd_alg in svd_algs
+            n < m && svd_alg isa rocSOLVER_QRIteration && continue 
+            A = ROCArray(randn(rng, T, m, n))
+            alg = PolarViaSVD(svd_alg)
+            W, P = left_polar(A; alg)
+            @test W isa ROCMatrix{T} && size(W) == (m, n)
+            @test P isa ROCMatrix{T} && size(P) == (n, n)
+            @test W * P ≈ A
+            @test isisometry(W)
+            #@test isposdef(P)
+
+            Ac = similar(A)
+            W2, P2 = @constinferred left_polar!(copy!(Ac, A), (W, P), alg)
+            @test W2 === W
+            @test P2 === P
+            @test W * P ≈ A
+            @test isisometry(W)
+            #@test isposdef(P)
+        end
+    end
+end
+
+@testset "right_polar! for T = $T" for T in (Float32, Float64, ComplexF32, ComplexF64)
+    rng = StableRNG(123)
+    n = 54
+    @testset "size ($m, $n)" for m in (37, n)
+        k = min(m, n)
+        svd_algs = (rocSOLVER_QRIteration(), rocSOLVER_Jacobi())
+        @testset "algorithm $svd_alg" for svd_alg in svd_algs
+            n > m && svd_alg isa rocSOLVER_QRIteration && continue 
+            A = ROCArray(randn(rng, T, m, n))
+            alg = PolarViaSVD(svd_alg)
+            P, Wᴴ = right_polar(A; alg)
+            @test Wᴴ isa ROCMatrix{T} && size(Wᴴ) == (m, n)
+            @test P  isa ROCMatrix{T} && size(P) == (m, m)
+            @test P * Wᴴ ≈ A
+            @test isisometry(Wᴴ; side=:right)
+            #@test isposdef(P)
+
+            Ac = similar(A)
+            P2, Wᴴ2 = @constinferred right_polar!(copy!(Ac, A), (P, Wᴴ), alg)
+            @test P2 === P
+            @test Wᴴ2 === Wᴴ
+            @test P * Wᴴ ≈ A
+            @test isisometry(Wᴴ; side=:right)
+            #@test isposdef(P)
+        end
+    end
+end

test/runtests.jl

@@ -94,9 +94,9 @@ if AMDGPU.functional()
     @safetestset "AMDGPU Hermitian Eigenvalue Decomposition" begin
         include("amd/eigh.jl")
     end
-    @safetestset "AMDGPU Schur Decomposition" begin
+    #=@safetestset "AMDGPU Schur Decomposition" begin
         include("amd/schur.jl")
-    end
+    end=# #TODO
     @safetestset "AMDGPU Polar Decomposition" begin
         include("amd/polar.jl")
     end