Support GenericFloats too

Author: Katharine Hyatt

ext/MatrixAlgebraKitGenericLinearAlgebraExt.jl

@@ -2,6 +2,7 @@ module MatrixAlgebraKitGenericLinearAlgebraExt
 
 using MatrixAlgebraKit
 using MatrixAlgebraKit: sign_safe, check_input, diagview, gaugefix!, one!, default_fixgauge
+using MatrixAlgebraKit: left_orth_alg
 using GenericLinearAlgebra: svd!, svdvals!, eigen!, eigvals!, Hermitian, qr!
 using LinearAlgebra: I, Diagonal, lmul!
 
@@ -133,4 +134,6 @@ function MatrixAlgebraKit.default_lq_algorithm(::Type{T}; kwargs...) where {T <:
     return MatrixAlgebraKit.LQViaTransposedQR(GLA_HouseholderQR(; kwargs...))
 end
 
+MatrixAlgebraKit.left_orth_alg(alg::GLA_HouseholderQR) = MatrixAlgebraKit.LeftOrthViaQR(alg)
+
 end

test/linearmap.jl

@@ -3,7 +3,8 @@ module LinearMaps
     export LinearMap
 
     using MatrixAlgebraKit
-    using MatrixAlgebraKit: AbstractAlgorithm, DiagonalAlgorithm
+    using MatrixAlgebraKit: AbstractAlgorithm, DiagonalAlgorithm, GLA_QRIteration
+    using GenericLinearAlgebra
     import MatrixAlgebraKit as MAK
 
     using LinearAlgebra: LinearAlgebra, lmul!, rmul!
@@ -30,8 +31,12 @@ module LinearMaps
             MAK.check_input($f!, parent(A), parent.(F), alg)
         @eval MAK.initialize_output(::typeof($f!), A::LinearMap, alg::AbstractAlgorithm) =
             LinearMap.(MAK.initialize_output($f!, parent(A), alg))
+        @eval MAK.initialize_output(::typeof($f!), A::LinearMap, alg::GLA_QRIteration) =
+            (nothing, nothing, nothing)
         @eval MAK.$f!(A::LinearMap, F, alg::AbstractAlgorithm) =
             LinearMap.(MAK.$f!(parent(A), parent.(F), alg))
+        @eval MAK.$f!(A::LinearMap, F, alg::GLA_QRIteration) =
+            LinearMap.(MAK.$f!(parent(A), F, alg))
         @eval MAK.check_input(::typeof($f!), A::LinearMap, F, alg::DiagonalAlgorithm) =
             MAK.check_input($f!, parent(A), parent.(F), alg)
         @eval MAK.initialize_output(::typeof($f!), A::LinearMap, alg::DiagonalAlgorithm) =

test/orthnull.jl

@@ -6,7 +6,7 @@ using LinearAlgebra: LinearAlgebra, I, Diagonal
 using CUDA, AMDGPU
 
 BLASFloats = (Float32, Float64, ComplexF32, ComplexF64)
-GenericFloats = (Float16, BigFloat, Complex{BigFloat})
+GenericFloats = (BigFloat, Complex{BigFloat})
 
 @isdefined(TestSuite) || include("testsuite/TestSuite.jl")
 using .TestSuite
@@ -27,9 +27,7 @@ for T in (BLASFloats..., GenericFloats...), n in (37, m, 63)
         end
     end
     if !is_buildkite
-        if T ∈ BLASFloats # no qr_null or lq_null for GenericFloats
-            TestSuite.test_orthnull(T, (m, n))
-        end
+        TestSuite.test_orthnull(T, (m, n))
         #AT = Diagonal{T, Vector{T}}
         #TestSuite.test_orthnull(AT, m) # not supported
     end