Skip to content

Commit 99e4611

Browse files
authored
Small fixes and improvements (#57)
1 parent 2d6443e commit 99e4611

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

src/interface/decompositions.jl

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -163,15 +163,17 @@ a general matrix using the Jacobi algorithm.
163163
@algdef CUSOLVER_Jacobi
164164

165165
"""
166-
CUSOLVER_Randomized(; p, niters)
166+
CUSOLVER_Randomized(; k, p, niters)
167167
168168
Algorithm type to denote the CUSOLVER driver for computing the singular value decomposition of
169-
a general matrix using the randomized SVD algorithm.
170-
171-
!!! note
172-
Randomized SVD cannot compute all singular values of the input matrix `A`, only the first `k` where
173-
`k < min(m, n)`. The remainder are used for oversampling. See the [CUSOLVER documentation](https://docs.nvidia.com/cuda/cusolver/index.html#cusolverdnxgesvdr)
174-
for more information.
169+
a general matrix using the randomized SVD algorithm. Here, `k` denotes the number of singular
170+
values that should be computed, therefore requiring `k <= min(size(A))`. This method is accurate
171+
for small values of `k` compared to the size of the input matrix, where the accuracy can be
172+
improved by increasing `p`, the number of additional values used for oversampling,
173+
and `niters`, the number of iterations the solver uses, at the cost of increasing the runtime.
174+
175+
See also the [CUSOLVER documentation](https://docs.nvidia.com/cuda/cusolver/index.html#cusolverdnxgesvdr)
176+
for more information.
175177
"""
176178
@algdef CUSOLVER_Randomized
177179

test/gen_eig.jl

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,6 @@ using LinearAlgebra: Diagonal
2929
@test V2 === V
3030
@test A * V B * V * Diagonal(W)
3131

32-
Ac = similar(A)
33-
Bc = similar(B)
3432
W2, V2 = @constinferred gen_eig_full!(copy!(Ac, A), copy!(Bc, B), (W, V))
3533
@test W2 === W
3634
@test V2 === V

0 commit comments

Comments
 (0)