Skip to content

Commit 9df9060

Browse files
committed
fix gelqt call
1 parent 3bee5cd commit 9df9060

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

src/yalapack.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -284,7 +284,7 @@ for (geqr, gelq, geqrf, gelqf, geqlf, gerqf, geqrt, gelqt, latsqr, laswlq, geqp3
284284
minmn == 0 && return A, T
285285
lda = max(1, stride(A, 2))
286286
ldt = max(1, stride(T, 2))
287-
work = Vector{$elty}(undef, mb * n)
287+
work = Vector{$elty}(undef, mb * m)
288288
info = Ref{BlasInt}()
289289
ccall((@blasfunc($gelqt), libblastrampoline), Cvoid,
290290
(Ref{BlasInt}, Ref{BlasInt}, Ref{BlasInt}, Ptr{$elty}, Ref{BlasInt},

test/lq.jl

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -42,13 +42,12 @@
4242
@test_throws ArgumentError lq_compact!(copy!(Q2, A), (noL, Q2); positive=true)
4343
@test_throws ArgumentError lq_compact!(copy!(Q2, A), (noL, Q2); blocksize=8)
4444
end
45-
# other blocking: somehow blocksize<18 leads to strange memory errors
46-
lq_compact!(copy!(Ac, A), (L, Q); blocksize=18)
45+
lq_compact!(copy!(Ac, A), (L, Q); blocksize=8)
4746
@test L * Q A
4847
@test Q * Q' ≈ I
49-
lq_compact!(copy!(Ac, A), (noL, Q2); blocksize=18)
48+
lq_compact!(copy!(Ac, A), (noL, Q2); blocksize=8)
5049
@test Q == Q2
51-
lq_null!(copy!(Ac, A), Nᴴ; blocksize=18)
50+
lq_null!(copy!(Ac, A), Nᴴ; blocksize=8)
5251
@test maximum(abs, A * Nᴴ') < eps(real(T))^(2 / 3)
5352
@test Nᴴ * Nᴴ' ≈ I
5453
# pivoted

0 commit comments

Comments
 (0)