Skip to content

Commit 9e579be

Browse files
kshyattkshyatt
committed
Actually test GPU QR/LQ
1 parent 2ef4ab1 commit 9e579be

File tree

2 files changed

+62
-65
lines changed

2 files changed

+62
-65
lines changed

‎test/lq.jl‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ for T in (BLASFloats..., GenericFloats...), n in (37, m, 63)
1818
TestSuite.seed_rng!(123)
1919
if T ∈ BLASFloats
2020
if CUDA.functional()
21-
CUDA_LQ_ALGS = LQViaTransposedQR.(CUSOLVER_HouseholderLQ(; positive = false), CUSOLVER_HouseholderLQ(; positive = true))
21+
CUDA_LQ_ALGS = LQViaTransposedQR.((CUSOLVER_HouseholderQR(; positive = false), CUSOLVER_HouseholderQR(; positive = true)))
2222
TestSuite.test_lq(CuMatrix{T}, (m, n); test_pivoted = false, test_blocksize = false)
2323
TestSuite.test_lq_algs(CuMatrix{T}, (m, n), CUDA_LQ_ALGS)
2424
if n == m
@@ -27,7 +27,7 @@ for T in (BLASFloats..., GenericFloats...), n in (37, m, 63)
2727
end
2828
end
2929
if AMDGPU.functional()
30-
ROC_LQ_ALGS = LQViaTransposedQR.(ROCSOLVER_HouseholderLQ(; positive = false), ROCSOLVER_HouseholderLQ(; positive = true))
30+
ROC_LQ_ALGS = LQViaTransposedQR.((ROCSOLVER_HouseholderQR(; positive = false), ROCSOLVER_HouseholderQR(; positive = true)))
3131
TestSuite.test_lq(ROCMatrix{T}, (m, n); test_pivoted = false, test_blocksize = false)
3232
TestSuite.test_lq_algs(ROCMatrix{T}, (m, n), CUDA_LQ_ALGS)
3333
if n == m

‎test/runtests.jl‎

Lines changed: 60 additions & 63 deletions
Original file line numberDiff line numberDiff line change
@@ -2,73 +2,70 @@ using SafeTestsets
22

33
# don't run all tests on GPU, only the GPU
44
# specific ones
5-
is_buildkite = get(ENV, "BUILDKITE", "false") == "true"
6-
if !is_buildkite
7-
@safetestset "Algorithms" begin
8-
include("algorithms.jl")
9-
end
10-
@safetestset "Projections" begin
11-
include("projections.jl")
12-
end
13-
@safetestset "Truncate" begin
14-
include("truncate.jl")
15-
end
16-
@safetestset "QR / LQ Decomposition" begin
17-
include("qr.jl")
18-
include("lq.jl")
19-
end
20-
@safetestset "Singular Value Decomposition" begin
21-
include("svd.jl")
22-
end
23-
@safetestset "Hermitian Eigenvalue Decomposition" begin
24-
include("eigh.jl")
25-
end
26-
@safetestset "General Eigenvalue Decomposition" begin
27-
include("eig.jl")
28-
end
29-
@safetestset "Generalized Eigenvalue Decomposition" begin
30-
include("gen_eig.jl")
31-
end
32-
@safetestset "Schur Decomposition" begin
33-
include("schur.jl")
34-
end
35-
@safetestset "Polar Decomposition" begin
36-
include("polar.jl")
37-
end
38-
@safetestset "Image and Null Space" begin
39-
include("orthnull.jl")
40-
end
41-
@safetestset "Mooncake" begin
42-
include("mooncake.jl")
43-
end
44-
@safetestset "ChainRules" begin
45-
include("chainrules.jl")
5+
@safetestset "Algorithms" begin
6+
include("algorithms.jl")
7+
end
8+
@safetestset "Projections" begin
9+
include("projections.jl")
10+
end
11+
@safetestset "Truncate" begin
12+
include("truncate.jl")
13+
end
14+
@safetestset "QR / LQ Decomposition" begin
15+
include("qr.jl")
16+
include("lq.jl")
17+
end
18+
@safetestset "Singular Value Decomposition" begin
19+
include("svd.jl")
20+
end
21+
@safetestset "Hermitian Eigenvalue Decomposition" begin
22+
include("eigh.jl")
23+
end
24+
@safetestset "General Eigenvalue Decomposition" begin
25+
include("eig.jl")
26+
end
27+
@safetestset "Generalized Eigenvalue Decomposition" begin
28+
include("gen_eig.jl")
29+
end
30+
@safetestset "Schur Decomposition" begin
31+
include("schur.jl")
32+
end
33+
@safetestset "Polar Decomposition" begin
34+
include("polar.jl")
35+
end
36+
@safetestset "Image and Null Space" begin
37+
include("orthnull.jl")
38+
end
39+
@safetestset "Mooncake" begin
40+
include("mooncake.jl")
41+
end
42+
@safetestset "ChainRules" begin
43+
include("chainrules.jl")
44+
end
45+
@safetestset "MatrixAlgebraKit.jl" begin
46+
@safetestset "Code quality (Aqua.jl)" begin
47+
using MatrixAlgebraKit
48+
using Aqua
49+
Aqua.test_all(MatrixAlgebraKit)
4650
end
47-
@safetestset "MatrixAlgebraKit.jl" begin
48-
@safetestset "Code quality (Aqua.jl)" begin
49-
using MatrixAlgebraKit
50-
using Aqua
51-
Aqua.test_all(MatrixAlgebraKit)
52-
end
53-
@safetestset "Code linting (JET.jl)" begin
54-
using MatrixAlgebraKit
55-
using JET
56-
JET.test_package(MatrixAlgebraKit; target_defined_modules = true)
57-
end
51+
@safetestset "Code linting (JET.jl)" begin
52+
using MatrixAlgebraKit
53+
using JET
54+
JET.test_package(MatrixAlgebraKit; target_defined_modules = true)
5855
end
56+
end
5957

60-
using GenericLinearAlgebra
61-
@safetestset "Singular Value Decomposition" begin
62-
include("genericlinearalgebra/svd.jl")
63-
end
64-
@safetestset "Hermitian Eigenvalue Decomposition" begin
65-
include("genericlinearalgebra/eigh.jl")
66-
end
58+
using GenericLinearAlgebra
59+
@safetestset "Singular Value Decomposition" begin
60+
include("genericlinearalgebra/svd.jl")
61+
end
62+
@safetestset "Hermitian Eigenvalue Decomposition" begin
63+
include("genericlinearalgebra/eigh.jl")
64+
end
6765

68-
using GenericSchur
69-
@safetestset "General Eigenvalue Decomposition" begin
70-
include("genericschur/eig.jl")
71-
end
66+
using GenericSchur
67+
@safetestset "General Eigenvalue Decomposition" begin
68+
include("genericschur/eig.jl")
7269
end
7370

7471
using CUDA

0 commit comments

Comments
 (0)