Fix inplace vals rules

Author: kshyatt

ext/MatrixAlgebraKitMooncakeExt/MatrixAlgebraKitMooncakeExt.jl

@@ -139,14 +139,14 @@ for (f!, f, f_full, pb, adj) in (
             D, dD = arrayify(D_, dD_)
             # update primal
             DV = $f_full(A, Mooncake.primal(alg_dalg))
-            output = copy(diagview(DV[1]))
+            copy!(D, diagview(DV[1]))
             V = DV[2]
             function $adj(::Mooncake.NoRData)
                 $pb(dA, A, (D, V), (dD, nothing))
                 MatrixAlgebraKit.zero!(dD)
                 return Mooncake.NoRData(), Mooncake.NoRData(), Mooncake.NoRData(), Mooncake.NoRData()
             end
-            return Mooncake.CoDual(output, dD_), $adj
+            return D_dD, $adj
         end
         @is_primitive Mooncake.DefaultCtx Mooncake.ReverseMode Tuple{typeof($f), Any, MatrixAlgebraKit.AbstractAlgorithm}
         function Mooncake.rrule!!(::CoDual{typeof($f)}, A_dA::CoDual, alg_dalg::CoDual)
@@ -288,13 +288,13 @@ function Mooncake.rrule!!(::CoDual{typeof(MatrixAlgebraKit.svd_vals!)}, A_dA::Co
     A, dA = arrayify(A_, dA_)
     S, dS = arrayify(S_, dS_)
     U, nS, Vᴴ = svd_compact(A, Mooncake.primal(alg_dalg))
-    output = copy(diagview(nS))
+    copy!(S, diagview(nS))
     function dsvd_vals_adjoint(::Mooncake.NoRData)
         svd_pullback!(dA, A, (U, S, Vᴴ), (nothing, dS, nothing))
         MatrixAlgebraKit.zero!(dS)
         return Mooncake.NoRData(), Mooncake.NoRData(), Mooncake.NoRData(), Mooncake.NoRData()
     end
-    return Mooncake.CoDual(output, dS), dsvd_vals_adjoint
+    return S_dS, dsvd_vals_adjoint
 end
 
 @is_primitive Mooncake.DefaultCtx Mooncake.ReverseMode Tuple{typeof(MatrixAlgebraKit.svd_vals), Any, MatrixAlgebraKit.AbstractAlgorithm}