Comments

Author: kshyatt

ext/MatrixAlgebraKitGenericSchurExt.jl

@@ -13,18 +13,7 @@ MatrixAlgebraKit.initialize_output(::typeof(eig_full!), A::AbstractMatrix, ::GS_
 MatrixAlgebraKit.initialize_output(::typeof(eig_vals!), A::AbstractMatrix, ::GS_QRIteration) = nothing
 
 function MatrixAlgebraKit.eig_full!(A::AbstractMatrix, DV, ::GS_QRIteration)
-    D_, V_ = GenericSchur.eigen!(A)
-    D, V = DV
-    if !isnothing(D)
-        copyto!(D, Diagonal(D_))
-    else
-        D = D_
-    end
-    if !isnothing(V)
-        copyto!(V, V_)
-    else
-        V = V_
-    end
+    D, V = GenericSchur.eigen!(A)
     return Diagonal(D), V
 end
 

test/testsuite/eig.jl

@@ -34,9 +34,7 @@ function test_eig_full(
         @test A * V ≈ V * D
 
         D2, V2 = @testinferred eig_full!(Ac, (D, V))
-        @test D2 === D
-        @test V2 === V
-        @test A * V ≈ V * D
+        @test A * V2 ≈ V2 * D2
 
         Dc = @testinferred eig_vals(A)
         @test eltype(Dc) == Tc
@@ -59,9 +57,7 @@ function test_eig_full_algs(
         @test A * V ≈ V * D
 
         D2, V2 = @testinferred eig_full!(Ac, (D, V); alg)
-        @test D2 === D
-        @test V2 === V
-        @test A * V ≈ V * D
+        @test A * V2 ≈ V2 * D2
 
         Dc = @testinferred eig_vals(A; alg)
         @test eltype(Dc) == Tc