Jh/checkmacros #13
Merged
Jh/checkmacros #13
+152
−102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
🚀 New features to boost your workflow:
|
lkdvos
reviewed
Mar 21, 2025
Member
lkdvos
left a comment
lkdvos
left a comment
There was a problem hiding this comment.
Looks good to me.
Do you know if there would be a difference if we try to achieve the same thing with functions instead of macros? I have no strong opinions against this, it's just slightly more hidden what we are actually testing for now.
Member
Author
|
The macro is macro only in order to capture the symbol or expression of the variable, and have it printed in the error message. |
Co-authored-by: Lukas Devos <[email protected]>
lkdvos
approved these changes
Mar 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.