remove leftpolar and rightpolar

Author: lkdvos

src/TensorKit.jl

@@ -70,8 +70,8 @@ export inner, dot, norm, normalize, normalize!, tr
 
 # factorizations
 export mul!, lmul!, rmul!, adjoint!, pinv, axpy!, axpby!
-export leftorth, rightorth, leftnull, rightnull, leftpolar, rightpolar,
-       leftorth!, rightorth!, leftnull!, rightnull!, leftpolar!, rightpolar!,
+export leftorth, rightorth, leftnull, rightnull,
+       leftorth!, rightorth!, leftnull!, rightnull!,
        tsvd!, tsvd, eigen, eigen!, eig, eig!, eigh, eigh!, exp, exp!,
        isposdef, isposdef!, ishermitian, isisometry, isunitary, sylvester, rank, cond
 export braid, braid!, permute, permute!, transpose, transpose!, twist, twist!, repartition,

src/tensors/factorizations/factorizations.jl

@@ -7,7 +7,6 @@ export eig, eig!, eigh, eigh!
 export tsvd, tsvd!, svdvals, svdvals!
 export leftorth, leftorth!, rightorth, rightorth!
 export leftnull, leftnull!, rightnull, rightnull!
-export leftpolar, leftpolar!, rightpolar, rightpolar!
 export copy_oftype, permutedcopy_oftype
 export TruncationScheme, notrunc, truncbelow, truncerr, truncdim, truncspace
 

src/tensors/factorizations/implementations.jl

@@ -64,8 +64,6 @@ function leftnull!(t::AbstractTensorMap;
     end
 end
 
-leftpolar!(t::AbstractTensorMap; kwargs...) = left_polar!(t; kwargs...)
-
 function rightorth!(t::AbstractTensorMap;
                     alg::Union{LQ,LQpos,RQ,RQpos,SVD,SDD,Polar,Nothing}=nothing, kwargs...)
     InnerProductStyle(t) === EuclideanInnerProduct() ||
@@ -120,8 +118,6 @@ function rightnull!(t::AbstractTensorMap;
     end
 end
 
-rightpolar!(t::AbstractTensorMap; kwargs...) = right_polar!(t; kwargs...)
-
 # Eigenvalue decomposition
 # ------------------------
 function eigh!(t::AbstractTensorMap; trunc=notrunc(), kwargs...)

src/tensors/factorizations/interface.jl

@@ -182,20 +182,6 @@ Orthogonality requires `InnerProductStyle(t) <: HasInnerProduct`, and
 `InnerProductStyle(t) === EuclideanInnerProduct()`.
 """ rightnull, rightnull!
 
-@doc """
-    leftpolar(t::AbstractTensorMap, [(leftind, rightind)::Index2Tuple]; kwargs...) -> W, P
-    leftpolar!(t::AbstractTensorMap; kwargs...) -> W, P
-
-Compute the polar decomposition of tensor `t` as linear map from `rightind` to `leftind`.
-
-If `leftind` and `rightind` are not specified, the current partition of left and right
-indices of `t` is used. In that case, less memory is allocated if one allows the data in
-`t` to be destroyed/overwritten, by using `eigh!(t)`.
-
-See also [`rightpolar(!)`](@ref rightpolar).
-
-""" leftpolar, leftpolar!
-
 @doc """
     eigen(t::AbstractTensorMap, [(leftind, rightind)::Index2Tuple]; kwargs...) -> D, V
     eigen!(t::AbstractTensorMap; kwargs...) -> D, V
@@ -230,7 +216,7 @@ meaningless.
 """ isposdef(::AbstractTensorMap), isposdef!(::AbstractTensorMap)
 
 for f in
-    (:tsvd, :eig, :eigh, :eigen, :leftorth, :rightorth, :leftpolar, :rightpolar, :leftnull,
+    (:tsvd, :eig, :eigh, :eigen, :leftorth, :rightorth, :left_polar, :right_polar, :leftnull,
      :rightnull, :isposdef)
     f! = Symbol(f, :!)
     @eval function $f(t::AbstractTensorMap, p::Index2Tuple; kwargs...)

test/tensors.jl

@@ -686,8 +686,8 @@ for V in spacelist
             for T in (Float32, ComplexF64)
                 tA = rand(T, V1 ⊗ V3, V1 ⊗ V3)
                 tB = rand(T, V2 ⊗ V4, V2 ⊗ V4)
-                tA = 3 // 2 * leftpolar(tA)[1]
-                tB = 1 // 5 * leftpolar(tB)[1]
+                tA = 3 // 2 * left_polar(tA)[1]
+                tB = 1 // 5 * left_polar(tB)[1]
                 tC = rand(T, V1 ⊗ V3, V2 ⊗ V4)
                 t = @constinferred sylvester(tA, tB, tC)
                 @test codomain(t) == V1 ⊗ V3