Respond to comments

Author: Katharine Hyatt

src/auxiliary/linalg.jl

@@ -46,13 +46,5 @@ Base.adjoint(alg::Union{SVD,SDD,Polar}) = alg
 const OFA = OrthogonalFactorizationAlgorithm
 const SVDAlg = Union{SVD,SDD}
 
-function one!(A::StridedMatrix)
-    length(A) > 0 || return A
-    copyto!(A, LinearAlgebra.I)
-    return A
-end
-
 safesign(s::Real) = ifelse(s < zero(s), -one(s), +one(s))
 safesign(s::Complex) = ifelse(iszero(s), one(s), s / abs(s))
-
-_argmax(f, domain) = argmax(f, domain)

src/tensors/factorizations/factorizations.jl

@@ -7,11 +7,11 @@ export eig, eig!, eigh, eigh!
 export tsvd, tsvd!, svdvals, svdvals!
 export leftorth, leftorth!, rightorth, rightorth!
 export leftnull, leftnull!, rightnull, rightnull!
-export copy_oftype, permutedcopy_oftype
+export copy_oftype, permutedcopy_oftype, one!
 export TruncationScheme, notrunc, truncbelow, truncerr, truncdim, truncspace
 
 using ..TensorKit
-using ..TensorKit: AdjointTensorMap, SectorDict, OFA, blocktype, foreachblock
+using ..TensorKit: AdjointTensorMap, SectorDict, OFA, blocktype, foreachblock, one!
 
 using LinearAlgebra: LinearAlgebra, BlasFloat, Diagonal, svdvals, svdvals!
 import LinearAlgebra: eigen, eigen!, isposdef, isposdef!, ishermitian
@@ -41,6 +41,8 @@ include("matrixalgebrakit.jl")
 include("truncation.jl")
 include("deprecations.jl")
 
+TensorKit.one!(A::AbstractMatrix) = MatrixAlgebraKit.one!(A)
+
 function isisometry(t::AbstractTensorMap, (p₁, p₂)::Index2Tuple)
     t = permute(t, (p₁, p₂); copy=false)
     return isisometry(t)

test/ad.jl

@@ -447,8 +447,7 @@ Vlist = ((ℂ^2, (ℂ^3)', ℂ^3, ℂ^2, (ℂ^2)'),
             T <: Complex && remove_svdgauge_depence!(ΔU, ΔV, U, S, V)
             test_rrule(tsvd, C; atol, output_tangent=(ΔU, ΔS, ΔV))
 
-            c, = TensorKit._argmax(x -> sqrt(dim(x[1])) * maximum(diag(x[2])),
-                                                 blocks(S))
+            c, = argmax(x -> sqrt(dim(x[1])) * maximum(diag(x[2])), blocks(S))
             trunc = truncdim(round(Int, 2 * dim(c)))
             U, S, V = tsvd(C; trunc)
             ΔU = randn(scalartype(U), space(U))