isa's, CI friendliness, braiding conditions and todos

Author: borisdevos

test/symmetries/fusiontrees.jl

@@ -61,7 +61,7 @@ using .TestSetup
                 @constinferred FusionTree((u,), u, (false,))
                 @constinferred FusionTree((u, u), u, (false, false))
                 @constinferred FusionTree((u, u, u), u)
-                if isa(UnitStyle(I), SimpleUnit)
+                if UnitStyle(I) isa SimpleUnit
                     @constinferred FusionTree((u, u, u, u))
                 else
                     @test_throws ArgumentError FusionTree((u, u, u, u))
@@ -72,7 +72,7 @@ using .TestSetup
                 @test_throws ArgumentError FusionTree((u,), u, (false,))
                 @test_throws ArgumentError FusionTree((u, u), u, (false, false))
                 @test_throws ArgumentError FusionTree((u, u, u), u)
-                if I <: ProductSector && isa(UnitStyle(I), GenericUnit)
+                if I <: ProductSector && UnitStyle(I) isa GenericUnit
                     @test_throws DomainError FusionTree((u, u, u, u))
                 else
                     @test_throws ArgumentError FusionTree((u, u, u, u))
@@ -89,7 +89,7 @@ using .TestSetup
         for i in 1:N
             out1 = random_fusion(I, Val(N)) # guaranteed good fusion
             out1 = Base.setindex(out1, in2, i) # can lead to poor fusion
-            while isempty(⊗(out1...))
+            while isempty(⊗(out1...)) # TODO: better way to do this?
                 out1 = random_fusion(I, Val(N))
                 out1 = Base.setindex(out1, in2, i)
             end
@@ -105,7 +105,7 @@ using .TestSetup
             @test length(TK.insertat(f1b, 1, f1a)) == 1
             @test first(TK.insertat(f1b, 1, f1a)) == (f1 => 1)
 
-            if isa(UnitStyle(I), SimpleUnit)
+            if UnitStyle(I) isa SimpleUnit
                 levels = ntuple(identity, N)
                 function _reinsert_partial_tree(t, f)
                     (t′, c′) = first(TK.insertat(t, 1, f))
@@ -237,7 +237,7 @@ using .TestSetup
             end
         end
     end
-    (UnitStyle(I) == SimpleUnit) && @testset "Fusion tree $Istr: elementary artin braid" begin
+    (BraidingStyle(I) isa HasBraiding) && @testset "Fusion tree $Istr: elementary artin braid" begin
         N = length(out)
         isdual = ntuple(n -> rand(Bool), N)
         for in in ⊗(out...)
@@ -293,7 +293,7 @@ using .TestSetup
             end
         end
     end
-    (UnitStyle(I) == SimpleUnit) && @testset "Fusion tree $Istr: braiding and permuting" begin
+    (BraidingStyle(I) isa HasBraiding) && @testset "Fusion tree $Istr: braiding and permuting" begin
         f = rand(collect(it))
         p = tuple(randperm(N)...)
         ip = invperm(p)
@@ -355,7 +355,7 @@ using .TestSetup
                 for (f, coeff) in TK.merge(f1, f2, c, μ)
         )
 
-        if !isa(BraidingStyle(I), NoBraiding)
+        if BraidingStyle(I) isa HasBraiding
             for c in in1 ⊗ in2
                 R = Rsymbol(in1, in2, c)
                 for μ in 1:Nsymbol(in1, in2, c)
@@ -411,7 +411,7 @@ using .TestSetup
     else
         N = 4
     end
-    if isa(UnitStyle(I), SimpleUnit)
+    if UnitStyle(I) isa SimpleUnit
         out = random_fusion(I, Val(N))
         numtrees = count(n -> true, fusiontrees((out..., map(dual, out)...)))
         while !(0 < numtrees < 100)

test/symmetries/spaces.jl

@@ -235,7 +235,7 @@ end
 
     @test isunitspace(W)
     @test @constinferred(unitspace(V)) == W == unitspace(typeof(V))
-    if isa(UnitStyle(I), SimpleUnit)
+    if UnitStyle(I) isa SimpleUnit
         @test @constinferred(leftunitspace(V)) == W == @constinferred(rightunitspace(V))
     else
         @test_throws ArgumentError leftunitspace(V)

test/tensors/factorizations.jl

@@ -9,9 +9,9 @@ spacelist = try
     if ENV["CI"] == "true"
         println("Detected running on CI")
         if Sys.iswindows()
-            (Vtr, Vℤ₃, VU₁, VfU₁, VCU₁, VSU₂, VIB_diag, VIB_M)
+            (Vtr, Vℤ₃, VU₁, VfU₁, VCU₁, VSU₂, VIB_diag)
         elseif Sys.isapple()
-            (Vtr, Vℤ₃, VfU₁, VfSU₂, VIB_diag, VIB_M)
+            (Vtr, Vℤ₃, VfU₁, VfSU₂, VIB_M)
         else
             (Vtr, VU₁, VCU₁, VSU₂, VfSU₂, VIB_diag, VIB_M)
         end

test/tensors/tensors.jl

@@ -11,9 +11,9 @@ spacelist = try
     if get(ENV, "CI", "false") == "true"
         println("Detected running on CI")
         if Sys.iswindows()
-            (Vtr, Vℤ₂, Vfℤ₂, Vℤ₃, VU₁, VfU₁, VCU₁, VSU₂, VIB_diag, VIB_M)
+            (Vtr, Vℤ₂, Vfℤ₂, Vℤ₃, VU₁, VfU₁, VCU₁, VSU₂, VIB_diag)
         elseif Sys.isapple()
-            (Vtr, Vℤ₂, Vfℤ₂, Vℤ₃, VfU₁, VfSU₂, VSU₂U₁, VIB_diag, VIB_M) #, VSU₃)
+            (Vtr, Vℤ₂, Vfℤ₂, Vℤ₃, VfU₁, VfSU₂, VSU₂U₁, VIB_M) #, VSU₃)
         else
             (Vtr, Vℤ₂, Vfℤ₂, VU₁, VCU₁, VSU₂, VfSU₂, VSU₂U₁, VIB_diag, VIB_M) #, VSU₃)
         end
@@ -27,7 +27,7 @@ end
 for V in spacelist
     I = sectortype(first(V))
     Istr = type_repr(I)
-    symmetricbraiding = isa(BraidingStyle(I), SymmetricBraiding)
+    symmetricbraiding = BraidingStyle(I) isa SymmetricBraiding
     println("---------------------------------------")
     println("Tensors with symmetry: $Istr")
     println("---------------------------------------")
@@ -137,7 +137,7 @@ for V in spacelist
                 @test dot(t2, t) ≈ conj(dot(t2', t'))
                 @test dot(t2, t) ≈ dot(t', t2')
 
-                if isa(UnitStyle(I), SimpleUnit) || !isempty(blocksectors(V2 ⊗ V1))
+                if UnitStyle(I) isa SimpleUnit || !isempty(blocksectors(V2 ⊗ V1))
                     i1 = @constinferred(isomorphism(T, V1 ⊗ V2, V2 ⊗ V1)) # can't reverse fusion here when modules are involved
                     i2 = @constinferred(isomorphism(Vector{T}, V2 ⊗ V1, V1 ⊗ V2))
                     @test i1 * i2 == @constinferred(id(T, V1 ⊗ V2))
@@ -329,7 +329,7 @@ for V in spacelist
             end
         end
         #TODO: find version that works for all multifusion cases
-        (UnitStyle(I) == SimpleUnit()) && @timedtestset "Trace and contraction" begin
+        symmetricbraiding && @timedtestset "Trace and contraction" begin
             t1 = rand(ComplexF64, V1 ⊗ V2 ⊗ V3)
             t2 = rand(ComplexF64, V2' ⊗ V4 ⊗ V1')
             t3 = t1 ⊗ t2
@@ -354,7 +354,7 @@ for V in spacelist
                 @test HrA12array ≈ convert(Array, HrA12)
             end
         end
-        (BraidingStyle(I) != NoBraiding()) && @timedtestset "Index flipping: test flipping inverse" begin
+        (BraidingStyle(I) isa HasBraiding) && @timedtestset "Index flipping: test flipping inverse" begin
             t = rand(ComplexF64, V1 ⊗ V1' ← V1' ⊗ V1)
             for i in 1:4
                 @test t ≈ flip(flip(t, i), i; inv = true)
@@ -533,7 +533,7 @@ for V in spacelist
         end
         @timedtestset "Tensor product: test via norm preservation" begin
             for T in (Float32, ComplexF64)
-                if isa(UnitStyle(I), SimpleUnit) || !isempty(blocksectors(V2 ⊗ V1))
+                if UnitStyle(I) isa SimpleUnit || !isempty(blocksectors(V2 ⊗ V1))
                     t1 = rand(T, V2 ⊗ V3 ⊗ V1, V1 ⊗ V2)
                     t2 = rand(T, V2 ⊗ V1 ⊗ V3, V1 ⊗ V1)
                 else
@@ -572,7 +572,7 @@ for V in spacelist
         end
         @timedtestset "Tensor absorption" begin
             # absorbing small into large
-            if isa(UnitStyle(I), SimpleUnit) || !isempty(blocksectors(V2 ⊗ V3))
+            if UnitStyle(I) isa SimpleUnit || !isempty(blocksectors(V2 ⊗ V3))
                 t1 = zeros(V1 ⊕ V1, V2 ⊗ V3)
                 t2 = rand(V1, V2 ⊗ V3)
             else
@@ -587,7 +587,7 @@ for V in spacelist
             @test t3 ≈ t4
 
             # absorbing large into small
-            if isa(UnitStyle(I), SimpleUnit) || !isempty(blocksectors(V2 ⊗ V3))
+            if UnitStyle(I) isa SimpleUnit || !isempty(blocksectors(V2 ⊗ V3))
                 t1 = rand(V1 ⊕ V1, V2 ⊗ V3)
                 t2 = zeros(V1, V2 ⊗ V3)
             else