improve type stability

Author: lkdvos

src/tensors/indexmanipulations.jl

@@ -308,11 +308,12 @@ If `copy=false`, `tdst` might share data with `tsrc` whenever possible. Otherwis
 
 This operation undoes the work of [`insertunit`](@ref).
 """
-function removeunit(t::TensorMap, i::Int; copy::Bool=false)
+Base.@constprop :aggressive function removeunit(t::TensorMap, i::Int; copy::Bool=false)
     W = removeunit(space(t), i)
     return TensorMap{scalartype(t)}(copy ? Base.copy(t.data) : t.data, W)
 end
-function removeunit(t::AbstractTensorMap, i::Int=numind(t) + 1; copy::Bool=true)
+Base.@constprop :aggressive function removeunit(t::AbstractTensorMap, i::Int;
+                                                copy::Bool=true)
     W = removeunit(space(t), i)
     tdst = similar(t, W)
     for (c, b) in blocks(t)

test/spaces.jl

@@ -422,7 +422,7 @@ println("------------------------------------")
         @test permute(W, ((2, 4, 5), (3, 1))) == (V2 ⊗ V4' ⊗ V5' ← V3 ⊗ V1')
         @test (V1 ⊗ V2 ← V1 ⊗ V2) == @constinferred TensorKit.compose(W, W')
         @test @constinferred(insertunit(W)) == (V1 ⊗ V2 ← V3 ⊗ V4 ⊗ V5 ⊗ oneunit(V5))
-        @test @constinferred(removeunit(insertunit(W), numind(W) + 1)) == W
+        @test @constinferred(removeunit(insertunit(W), $(numind(W) + 1))) == W
         @test @constinferred(insertunit(W; conj=true)) == (V1 ⊗ V2 ←
                                                            V3 ⊗ V4 ⊗ V5 ⊗ oneunit(V5)')
         @test @constinferred(insertunit(W, 1)) == (oneunit(V1) ⊗ V1 ⊗ V2 ← V3 ⊗ V4 ⊗ V5)

test/tensors.jl

@@ -182,13 +182,13 @@ for V in spacelist
                 @test space(t2) == insertunit(space(t))
                 @test scalartype(t2) === T
                 @test t.data === t2.data
-                @test @constinferred(removeunit(t2, numind(t2))) == t
+                @test @constinferred(removeunit(t2, $(numind(t2)))) == t
                 t3 = @constinferred insertunit(t; copy=true)
                 @test t.data !== t3.data
                 for (c, b) in blocks(t)
                     @test b == block(t3, c)
                 end
-                @test @constinferred(removeunit(t3, numind(t3))) == t
+                @test @constinferred(removeunit(t3, $(numind(t3)))) == t
                 t4 = @constinferred insertunit(t, 4; dual=true)
                 @test numin(t4) == numin(t) && numout(t4) == numout(t) + 1
                 for (c, b) in blocks(t)