Skip to content

Commit 3e47462

Browse files
committed
refrain from defining left_null functions to avoid ambiguities
1 parent d4a5d96 commit 3e47462

File tree

1 file changed

+12
-23
lines changed

1 file changed

+12
-23
lines changed

src/factorizations/adjoint.jl

Lines changed: 12 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -25,31 +25,20 @@ for f in
2525
end
2626

2727
# 1-arg functions
28-
function MAK.initialize_output(::typeof(left_null!), t::AdjointTensorMap, alg::AbstractAlgorithm)
29-
return adjoint(MAK.initialize_output(right_null!, adjoint(t), _adjoint(alg)))
30-
end
31-
function MAK.initialize_output(
32-
::typeof(right_null!), t::AdjointTensorMap,
33-
alg::AbstractAlgorithm
34-
)
35-
return adjoint(MAK.initialize_output(left_null!, adjoint(t), _adjoint(alg)))
36-
end
28+
MAK.initialize_output(::typeof(qr_null!), t::AdjointTensorMap, alg::AbstractAlgorithm) =
29+
adjoint(MAK.initialize_output(lq_null!, adjoint(t), _adjoint(alg)))
30+
MAK.initialize_output(::typeof(lq_null!), t::AdjointTensorMap, alg::AbstractAlgorithm) =
31+
adjoint(MAK.initialize_output(qr_null!, adjoint(t), _adjoint(alg)))
3732

38-
function MAK.left_null!(t::AdjointTensorMap, N, alg::AbstractAlgorithm)
39-
right_null!(adjoint(t), adjoint(N), _adjoint(alg))
40-
return N
41-
end
42-
function MAK.right_null!(t::AdjointTensorMap, N, alg::AbstractAlgorithm)
43-
left_null!(adjoint(t), adjoint(N), _adjoint(alg))
44-
return N
45-
end
33+
MAK.qr_null!(t::AdjointTensorMap, N, alg::AbstractAlgorithm) =
34+
lq_null!(adjoint(t), adjoint(N), _adjoint(alg))
35+
MAK.lq_null!(t::AdjointTensorMap, N, alg::AbstractAlgorithm) =
36+
qr_null!(adjoint(t), adjoint(N), _adjoint(alg))
4637

47-
function MAK.is_left_isometric(t::AdjointTensorMap; kwargs...)
48-
return MAK.is_right_isometric(adjoint(t); kwargs...)
49-
end
50-
function MAK.is_right_isometric(t::AdjointTensorMap; kwargs...)
51-
return MAK.is_left_isometric(adjoint(t); kwargs...)
52-
end
38+
MAK.is_left_isometric(t::AdjointTensorMap; kwargs...) =
39+
MAK.is_right_isometric(adjoint(t); kwargs...)
40+
MAK.is_right_isometric(t::AdjointTensorMap; kwargs...) =
41+
MAK.is_left_isometric(adjoint(t); kwargs...)
5342

5443
# 2-arg functions
5544
for (left_f, right_f) in zip(

0 commit comments

Comments
 (0)