Fix posdef and copy

Author: kshyatt

ext/TensorKitCUDAExt/cutensormap.jl

@@ -121,11 +121,15 @@ function LinearAlgebra.isposdef(t::CuTensorMap)
         # do our own hermitian check
         isherm = MatrixAlgebraKit.ishermitian(b; atol = eps(real(eltype(b))), rtol = eps(real(eltype(b))))
         isherm || return false
-        isposdef(Hermitian(b)) || return false
+        isposdef(project_hermitian!(b)) || return false
     end
     return true
 end
 
+function LinearAlgebra.isposdef(t::TensorKit.AdjointTensorMap{T, S, N₁, N₂, <:CuTensorMap}) where {T, S, N₁, N₂}
+    return isposdef(adjoint(t))
+end
+
 function Base.promote_rule(
         ::Type{<:TT₁},
         ::Type{<:TT₂}
@@ -164,11 +168,3 @@ for f in (:sqrt, :log, :asin, :acos, :acosh, :atanh, :acoth)
         return tf
     end
 end
-
-function Base.copy!(tdst::CuTensorMap, tsrc::AdjointTensorMap)
-    space(tdst) == space(tsrc) || throw(SpaceMismatch("$(space(tdst)) ≠ $(space(tsrc))"))
-    for ((c, bdst), (_, bsrc)) in zip(blocks(tdst), blocks(tsrc))
-        copy!(bdst, bsrc)
-    end
-    return tdst
-end

src/tensors/linalg.jl

@@ -197,13 +197,15 @@ LinearAlgebra.isdiag(t::AbstractTensorMap) = all(LinearAlgebra.isdiag ∘ last,
 # In-place methods
 #------------------
 # Wrapping the blocks in a StridedView enables multithreading if JULIA_NUM_THREADS > 1
+# but can cause problems with underlying array types (like CuArray) that don't yet play
+# nicely with StridedViews
 # TODO: reconsider this strategy, consider spawning different threads for different blocks
 
 # Copy, adjoint and fill:
 function Base.copy!(tdst::AbstractTensorMap, tsrc::AbstractTensorMap)
     space(tdst) == space(tsrc) || throw(SpaceMismatch("$(space(tdst)) ≠ $(space(tsrc))"))
     for ((c, bdst), (_, bsrc)) in zip(blocks(tdst), blocks(tsrc))
-        copy!(StridedView(bdst), StridedView(bsrc))
+        copy!(bdst, bsrc)
     end
     return tdst
 end

test/cuda/factorizations.jl

@@ -150,7 +150,7 @@ for V in spacelist
         end
 
         @testset "Polar decomposition" begin
-            for T in eltypes,
+            @testset for T in eltypes,
                     t in (
                         CUDA.rand(T, W, W),
                         CUDA.rand(T, W, W)',
@@ -163,14 +163,14 @@ for V in spacelist
                 w, p = @constinferred left_polar(t)
                 @test w * p ≈ t
                 @test isisometric(w)
-                @test isposdef(project_hermitian!(p))
+                @test isposdef(p)
 
                 w, p = @constinferred left_orth(t; alg = :polar)
                 @test w * p ≈ t
                 @test isisometric(w)
             end
 
-            for T in eltypes,
+            @testset for T in eltypes,
                     t in (
                         CUDA.rand(T, W, W),
                         CUDA.rand(T, W, W)',
@@ -182,7 +182,7 @@ for V in spacelist
                 p, wᴴ = @constinferred right_polar(t)
                 @test p * wᴴ ≈ t
                 @test isisometric(wᴴ; side = :right)
-                @test isposdef(project_hermitian!(p))
+                @test isposdef(p)
 
                 p, wᴴ = @constinferred right_orth(t; alg = :polar)
                 @test p * wᴴ ≈ t