fix dim and revert unnecessary Int converts

Author: borisdevos

src/spaces/gradedspace.jl

@@ -92,8 +92,8 @@ Base.hash(V::GradedSpace, h::UInt) = hash(V.dual, hash(V.dims, h))
 field(::Type{<:GradedSpace}) = ℂ
 InnerProductStyle(::Type{<:GradedSpace}) = EuclideanInnerProduct()
 function dim(V::GradedSpace)
-    T = promote_type(Int, real(sectorscalartype(sectortype(V))))
-     return sum(dim(V, c) * dim(c) for c in sectors(V); init = zero(T))
+    s = sectors(V)
+    return isempty(s) ? dim(first(allunits(sectortype(V)))) * 0 : sum(c -> dim(c) * dim(V, c), s)
 end
 function dim(V::GradedSpace{I, <:AbstractDict}, c::I) where {I <: Sector}
     return get(V.dims, isdual(V) ? dual(c) : c, 0)

src/tensors/abstracttensor.jl

@@ -617,7 +617,7 @@ function Base.convert(::Type{Array}, t::AbstractTensorMap)
         dom = domain(t)
         T = sectorscalartype(I) <: Complex ? complex(scalartype(t)) :
             sectorscalartype(I) <: Integer ? scalartype(t) : float(scalartype(t))
-        A = zeros(T, Int.(dims(t))...)
+        A = zeros(T, dims(t)...)
         for (f₁, f₂) in fusiontrees(t)
             F = convert(Array, (f₁, f₂))
             Aslice = StridedView(A)[axes(cod, f₁.uncoupled)..., axes(dom, f₂.uncoupled)...]

src/tensors/tensor.jl

@@ -333,7 +333,7 @@ function TensorMap(
     # dimension check
     codom = codomain(V)
     dom = domain(V)
-    arraysize = Int.(dims(V))
+    arraysize = dims(V)
     matsize = (dim(codom), dim(dom))
 
     if !(size(data) == arraysize || size(data) == matsize)

test/tensors/factorizations.jl

@@ -237,7 +237,7 @@ for V in spacelist
                 @test isisometry(Vᴴ; side = :right)
 
                 #FIXME: dimension of S is a float, might be a real issue if it's a decimal
-                trunc = truncrank(Int(dim(domain(S)) ÷ 2))
+                trunc = truncrank(dim(domain(S)) ÷ 2)
                 U1, S1, Vᴴ1 = @constinferred svd_trunc(t; trunc)
                 @test t * Vᴴ1' ≈ U1 * S1
                 @test isisometry(U1)
@@ -269,7 +269,7 @@ for V in spacelist
                 @test isisometry(Vᴴ4; side = :right)
                 @test norm(t - U4 * S4 * Vᴴ4) <= 0.5
 
-                trunc = truncrank(Int(dim(domain(S)) ÷ 2)) & trunctol(; atol = λ - 10eps(λ))
+                trunc = truncrank(dim(domain(S)) ÷ 2) & trunctol(; atol = λ - 10eps(λ))
                 U5, S5, Vᴴ5 = @constinferred svd_trunc(t; trunc)
                 @test t * Vᴴ5' ≈ U5 * S5
                 @test isisometry(U5)
@@ -299,7 +299,7 @@ for V in spacelist
                 @test @constinferred isposdef(vdv)
                 t isa DiagonalTensorMap || @test !isposdef(t) # unlikely for non-hermitian map
 
-                d, v = @constinferred eig_trunc(t; trunc = truncrank(Int(dim(domain(t)) ÷ 2)))
+                d, v = @constinferred eig_trunc(t; trunc = truncrank(dim(domain(t)) ÷ 2))
                 @test t * v ≈ v * d
                 @test dim(domain(d)) ≤ dim(domain(t)) ÷ 2
 
@@ -330,7 +330,7 @@ for V in spacelist
                 @test isposdef(t - λ * one(t) + 0.1 * one(t))
                 @test !isposdef(t - λ * one(t) - 0.1 * one(t))
 
-                d, v = @constinferred eigh_trunc(t; trunc = truncrank(Int(dim(domain(t)) ÷ 2)))
+                d, v = @constinferred eigh_trunc(t; trunc = truncrank(dim(domain(t)) ÷ 2))
                 @test t * v ≈ v * d
                 @test dim(domain(d)) ≤ dim(domain(t)) ÷ 2
             end

test/tensors/tensors.jl

@@ -85,14 +85,14 @@ for V in spacelist
                             t = @constinferred randn(T, W)
                         end
                         a = @constinferred convert(Array, t)
-                        b = reshape(a, Int(dim(codomain(W))), Int(dim(domain(W)))) # no init in dim makes reshape error for su2
+                        b = reshape(a, dim(codomain(W)), dim(domain(W)))
                         @test t ≈ @constinferred TensorMap(a, W)
                         @test t ≈ @constinferred TensorMap(b, W)
                         @test t === @constinferred TensorMap(t.data, W)
                     end
                 end
                 for T in (Int, Float32, ComplexF64)
-                    t = randn(T, V1 ⊗ V2 ← zerospace(V1)) # no init in dim makes zerospace call error for z2
+                    t = randn(T, V1 ⊗ V2 ← zerospace(V1))
                     a = convert(Array, t)
                     @test norm(a) == 0
                 end
@@ -427,8 +427,8 @@ for V in spacelist
                     t1 = rand(T, W1 ← W1)
                     t2 = rand(T, W2, W2)
                     t = rand(T, W1 ← W2)
-                    d1 = Int(dim(W1))
-                    d2 = Int(dim(W2))
+                    d1 = dim(W1)
+                    d2 = dim(W2)
                     At1 = reshape(convert(Array, t1), d1, d1)
                     At2 = reshape(convert(Array, t2), d2, d2)
                     At = reshape(convert(Array, t), d1, d2)
@@ -469,7 +469,7 @@ for V in spacelist
                 W = V1 ⊗ V2
                 for T in (Float64, ComplexF64)
                     t = randn(T, W, W)
-                    s = Int(dim(W))
+                    s = dim(W)
                     expt = @constinferred exp(t)
                     @test reshape(convert(Array, expt), (s, s)) ≈
                         exp(reshape(convert(Array, t), (s, s)))
@@ -529,7 +529,7 @@ for V in spacelist
                 @test norm(tA * t + t * tB + tC) <
                     (norm(tA) + norm(tB) + norm(tC)) * eps(real(T))^(2 / 3)
                 if BraidingStyle(I) isa Bosonic && hasfusiontensor(I)
-                    matrix(x) = reshape(convert(Array, x), Int(dim(codomain(x))), Int(dim(domain(x))))
+                    matrix(x) = reshape(convert(Array, x), dim(codomain(x)), dim(domain(x)))
                     @test matrix(t) ≈ sylvester(matrix(tA), matrix(tB), matrix(tC))
                 end
             end
@@ -553,10 +553,10 @@ for V in spacelist
                     t1 = rand(T, V2 ⊗ V3 ⊗ V1, V1)
                     t2 = rand(T, V2 ⊗ V1 ⊗ V3, V2)
                     t = @constinferred (t1 ⊗ t2)
-                    d1 = Int(dim(codomain(t1)))
-                    d2 = Int(dim(codomain(t2)))
-                    d3 = Int(dim(domain(t1)))
-                    d4 = Int(dim(domain(t2)))
+                    d1 = dim(codomain(t1))
+                    d2 = dim(codomain(t2))
+                    d3 = dim(domain(t1))
+                    d4 = dim(domain(t2))
                     At = convert(Array, t)
                     @test reshape(At, (d1, d2, d3, d4)) ≈
                         reshape(convert(Array, t1), (d1, 1, d3, 1)) .*
@@ -618,10 +618,10 @@ end
             t1 = rand(T, V1 ⊗ V2, V3' ⊗ V4)
             t2 = rand(T, W2, W1 ⊗ W1')
             t = @constinferred (t1 ⊠ t2)
-            d1 = Int(dim(codomain(t1)))
-            d2 = Int(dim(codomain(t2)))
-            d3 = Int(dim(domain(t1)))
-            d4 = Int(dim(domain(t2)))
+            d1 = dim(codomain(t1))
+            d2 = dim(codomain(t2))
+            d3 = dim(domain(t1))
+            d4 = dim(domain(t2))
             At = convert(Array, t)
             @test reshape(At, (d1, d2, d3, d4)) ≈
                 reshape(convert(Array, t1), (d1, 1, d3, 1)) .*