remove some boilerplate and disambiguate

Author: lkdvos

src/tensors/factorizations/diagonal.jl

@@ -105,6 +105,9 @@ for f! in (:lq_full!, :lq_compact!)
     end
 end
 
+# disambiguate
+svd_compact!(t::AbstractTensorMap, USVᴴ, alg::DiagonalAlgorithm) = svd_full!(t, USVᴴ, alg)
+
 # f_vals
 # ------
 

src/tensors/factorizations/matrixalgebrakit.jl

@@ -154,6 +154,7 @@ function initialize_output(::typeof(svd_compact!), t::AbstractTensorMap,
     return U, S, Vᴴ
 end
 
+# TODO: remove this once `AbstractMatrix` specialization is removed in MatrixAlgebraKit
 function initialize_output(::typeof(svd_trunc!), t::AbstractTensorMap,
                            alg::TruncatedAlgorithm)
     return initialize_output(svd_compact!, t, alg.alg)
@@ -165,11 +166,6 @@ function initialize_output(::typeof(svd_vals!), t::AbstractTensorMap,
     return DiagonalTensorMap{real(scalartype(t))}(undef, V_cod)
 end
 
-function svd_trunc!(t::AbstractTensorMap, USVᴴ, alg::TruncatedAlgorithm)
-    USVᴴ′ = svd_compact!(t, USVᴴ, alg.alg)
-    return truncate!(svd_trunc!, USVᴴ′, alg.trunc)
-end
-
 # Eigenvalue decomposition
 # ------------------------
 function check_input(::typeof(eigh_full!), t::AbstractTensorMap, DV, ::AbstractAlgorithm)
@@ -284,26 +280,6 @@ function initialize_output(::typeof(eig_vals!), t::AbstractTensorMap,
     return D = DiagonalTensorMap{Tc}(undef, V_D)
 end
 
-function initialize_output(::typeof(eigh_trunc!), t::AbstractTensorMap,
-                           alg::TruncatedAlgorithm)
-    return initialize_output(eigh_full!, t, alg.alg)
-end
-
-function initialize_output(::typeof(eig_trunc!), t::AbstractTensorMap,
-                           alg::TruncatedAlgorithm)
-    return initialize_output(eig_full!, t, alg.alg)
-end
-
-function eigh_trunc!(t::AbstractTensorMap, DV, alg::TruncatedAlgorithm)
-    DV′ = eigh_full!(t, DV, alg.alg)
-    return truncate!(eigh_trunc!, DV′, alg.trunc)
-end
-
-function eig_trunc!(t::AbstractTensorMap, DV, alg::TruncatedAlgorithm)
-    DV′ = eig_full!(t, DV, alg.alg)
-    return truncate!(eig_trunc!, DV′, alg.trunc)
-end
-
 # QR decomposition
 # ----------------
 function check_input(::typeof(qr_full!), t::AbstractTensorMap, QR, ::AbstractAlgorithm)