add code suggestions

Author: lkdvos

test/runtests.jl

@@ -22,7 +22,7 @@ if isempty(settings[:groups])
     if haskey(ENV, "GROUP")
         groups = [ENV["GROUP"]]
     else
-        groups = filter(isdir, readdir(@__DIR__))
+        groups = filter(isdir ∘ Base.Fix1(joinpath, @__DIR__), readdir(@__DIR__))
     end
 else
     groups = settings[:groups]
@@ -32,6 +32,8 @@ checktestgroup(group) = isdir(joinpath(@__DIR__, group)) ||
     throw(ArgumentError("Invalid group ($group), no such folder"))
 foreach(checktestgroup, groups)
 
+@info "Loaded test groups:" groups
+
 # don't run all tests on GPU, only the GPU specific ones
 is_buildkite = get(ENV, "BUILDKITE", "false") == "true"
 

test/setup.jl

@@ -4,16 +4,10 @@ export smallset, randsector, hasfusiontensor, force_planar
 export sectorlist
 export Vtr, Vℤ₂, Vfℤ₂, Vℤ₃, VU₁, VfU₁, VCU₁, VSU₂, VfSU₂, VSU₂U₁, Vfib
 
-using Test
-using TestExtras
 using Random
 using TensorKit
-using Combinatorics
-using TensorKit: ProductSector, fusiontensor, pentagon_equation, hexagon_equation
 using TensorKit: ℙ, PlanarTrivial
-using TensorOperations
 using Base.Iterators: take, product
-using LinearAlgebra: LinearAlgebra
 
 Random.seed!(1234)
 
@@ -38,7 +32,7 @@ function randsector(::Type{I}) where {I <: Sector}
 end
 function hasfusiontensor(I::Type{<:Sector})
     try
-        fusiontensor(one(I), one(I), one(I))
+        TensorKit.fusiontensor(one(I), one(I), one(I))
         return true
     catch e
         if e isa MethodError

test/symmetries/spaces.jl

@@ -8,13 +8,22 @@ using TensorKitSectors
 @isdefined(TestSetup) || include("../setup.jl")
 using .TestSetup
 
-parse_show(x) = Meta.parse(sprint(show, x; context = (:module => @__MODULE__)))
+"""
+    eval_show(x)
+
+Use `show` to generate a string representation of `x`, then parse and evaluate the resulting expression.
+"""
+function eval_show(x)
+    str = sprint(show, x; context = (:module => @__MODULE__))
+    ex = Meta.parse(str)
+    return eval(ex)
+end
 
 @timedtestset "Fields" begin
     @test isa(ℝ, Field)
     @test isa(ℂ, Field)
-    @test eval(parse_show(ℝ)) == ℝ
-    @test eval(parse_show(ℂ)) == ℂ
+    @test eval_show(ℝ) == ℝ
+    @test eval_show(ℂ) == ℂ
     @test ℝ ⊆ ℝ
     @test ℝ ⊆ ℂ
     @test ℂ ⊆ ℂ
@@ -55,8 +64,8 @@ end
 @timedtestset "ElementarySpace: CartesianSpace" begin
     d = 2
     V = ℝ^d
-    @test eval(parse_show(V)) == V
-    @test eval(parse_show(typeof(V))) == typeof(V)
+    @test eval_show(V) == V
+    @test eval_show(typeof(V)) == typeof(V)
     @test isa(V, VectorSpace)
     @test isa(V, ElementarySpace)
     @test isa(InnerProductStyle(V), HasInnerProduct)
@@ -99,9 +108,9 @@ end
 @timedtestset "ElementarySpace: ComplexSpace" begin
     d = 2
     V = ℂ^d
-    @test eval(parse_show(V)) == V
-    @test eval(parse_show(V')) == V'
-    @test eval(parse_show(typeof(V))) == typeof(V)
+    @test eval_show(V) == V
+    @test eval_show(V') == V'
+    @test eval_show(typeof(V)) == typeof(V)
     @test isa(V, VectorSpace)
     @test isa(V, ElementarySpace)
     @test isa(InnerProductStyle(V), HasInnerProduct)
@@ -151,10 +160,10 @@ end
 @timedtestset "ElementarySpace: GeneralSpace" begin
     d = 2
     V = GeneralSpace{ℂ}(d)
-    @test eval(parse_show(V)) == V
-    @test eval(parse_show(dual(V))) == dual(V)
-    @test eval(parse_show(conj(V))) == conj(V)
-    @test eval(parse_show(typeof(V))) == typeof(V)
+    @test eval_show(V) == V
+    @test eval_show(dual(V)) == dual(V)
+    @test eval_show(conj(V)) == conj(V)
+    @test eval_show(typeof(V)) == typeof(V)
     @test !isdual(V)
     @test isdual(V')
     @test !isdual(conj(V))
@@ -185,8 +194,8 @@ end
     end
     V = GradedSpace(gen)
     @test eval(Meta.parse(type_repr(typeof(V)))) == typeof(V)
-    @test eval(parse_show(V)) == V
-    @test eval(parse_show(V')) == V'
+    @test eval_show(V) == V
+    @test eval_show(V') == V'
     @test V' == GradedSpace(gen; dual = true)
     @test V == @constinferred GradedSpace(gen...)
     @test V' == @constinferred GradedSpace(gen...; dual = true)
@@ -207,8 +216,8 @@ end
     end
     @test @constinferred(hash(V)) == hash(deepcopy(V)) != hash(V')
     @test V == GradedSpace(reverse(collect(gen))...)
-    @test eval(parse_show(V)) == V
-    @test eval(parse_show(typeof(V))) == typeof(V)
+    @test eval_show(V) == V
+    @test eval_show(typeof(V)) == typeof(V)
     # space with no sectors
     @test dim(@constinferred(zerospace(V))) == 0
     # space with a single sector
@@ -218,7 +227,7 @@ end
     @test @constinferred(zerospace(V)) == GradedSpace(unit(I) => 0)
     # randsector never returns trivial sector, so this cannot error
     @test_throws ArgumentError GradedSpace(unit(I) => 1, randsector(I) => 0, unit(I) => 3)
-    @test eval(parse_show(W)) == W
+    @test eval_show(W) == W
     @test isa(V, VectorSpace)
     @test isa(V, ElementarySpace)
     @test isa(InnerProductStyle(V), HasInnerProduct)
@@ -263,8 +272,8 @@ end
 @timedtestset "ProductSpace{ℂ}" begin
     V1, V2, V3, V4 = ℂ^1, ℂ^2, ℂ^3, ℂ^4
     P = @constinferred ProductSpace(V1, V2, V3, V4)
-    @test eval(parse_show(P)) == P
-    @test eval(parse_show(typeof(P))) == typeof(P)
+    @test eval_show(P) == P
+    @test eval_show(typeof(P)) == typeof(P)
     @test isa(P, VectorSpace)
     @test isa(P, CompositeSpace)
     @test spacetype(P) == ComplexSpace
@@ -291,11 +300,11 @@ end
     @test fuse(flip(V1), V2, flip(V3)) ≅ V1 ⊗ V2 ⊗ V3
     @test @constinferred(⊗(P)) == P
     @test @constinferred(⊗(V1)) == ProductSpace(V1)
-    @test eval(parse_show(⊗(V1))) == ⊗(V1)
+    @test eval_show(⊗(V1)) == ⊗(V1)
     @test @constinferred(one(V1)) == @constinferred(one(typeof(V1))) ==
         @constinferred(one(P)) == @constinferred(one(typeof(P))) ==
         ProductSpace{ComplexSpace}(())
-    @test eval(parse_show(one(P))) == one(P)
+    @test eval_show(one(P)) == one(P)
     @test @constinferred(⊗(one(P), P)) == P
     @test @constinferred(⊗(P, one(P))) == P
     @test @constinferred(⊗(one(P), one(P))) == one(P)
@@ -330,8 +339,8 @@ end
     V1, V2, V3 = SU₂Space(0 => 3, 1 // 2 => 1), SU₂Space(0 => 2, 1 => 1),
         SU₂Space(1 // 2 => 1, 1 => 1)'
     P = @constinferred ProductSpace(V1, V2, V3)
-    @test eval(parse_show(P)) == P
-    @test eval(parse_show(typeof(P))) == typeof(P)
+    @test eval_show(P) == P
+    @test eval_show(typeof(P)) == typeof(P)
     @test isa(P, VectorSpace)
     @test isa(P, CompositeSpace)
     @test spacetype(P) == SU₂Space
@@ -409,8 +418,8 @@ end
         @test W == (V3 ⊗ V4 ⊗ V5 → V1 ⊗ V2)
         @test W == (V1 ⊗ V2 ← V3 ⊗ V4 ⊗ V5)
         @test W' == (V1 ⊗ V2 → V3 ⊗ V4 ⊗ V5)
-        @test eval(parse_show(W)) == W
-        @test eval(parse_show(typeof(W))) == typeof(W)
+        @test eval_show(W) == W
+        @test eval_show(typeof(W)) == typeof(W)
         @test spacetype(W) == typeof(V1)
         @test sectortype(W) == sectortype(V1)
         @test W[1] == V1

test/tensors/planar.jl

@@ -1,7 +1,7 @@
 using Test, TestExtras
 using TensorKit
-using TensorKit: planaradd!, planartrace!, planarcontract!
 using TensorKit: PlanarTrivial, ℙ
+using TensorKit: planaradd!, planartrace!, planarcontract!
 using TensorOperations
 
 @isdefined(TestSetup) || include("../setup.jl")