avoid one call in rank of tensormap

borisdevos · borisdevos · commit b114f649036e · 2025-11-03T16:35:54.000+01:00
diff --git a/src/tensors/linalg.jl b/src/tensors/linalg.jl
@@ -296,7 +296,7 @@ function LinearAlgebra.rank(
         t::AbstractTensorMap;
         atol::Real = 0, rtol::Real = atol > 0 ? 0 : _default_rtol(t)
     )
-    r = dim(one(sectortype(t))) * 0
+    r = zero(real(sectorscalartype(sectortype(t))))
     dim(t) == 0 && return r
     S = LinearAlgebra.svdvals(t)
     tol = max(atol, rtol * maximum(first, values(S)))

Original file line number	Diff line number	Diff line change
`@@ -296,7 +296,7 @@ function LinearAlgebra.rank(`
`296`	`296`	`t::AbstractTensorMap;`
`297`	`297`	`atol::Real = 0, rtol::Real = atol > 0 ? 0 : _default_rtol(t)`
`298`	`298`	`)`
`299`		`- r = dim(one(sectortype(t))) * 0`
	`299`	`+ r = zero(real(sectorscalartype(sectortype(t))))`
`300`	`300`	`dim(t) == 0 && return r`
`301`	`301`	`S = LinearAlgebra.svdvals(t)`
`302`	`302`	`tol = max(atol, rtol * maximum(first, values(S)))`