Skip to content

Commit b589658

Browse files
authored
Apply suggestions from code review
1 parent 3bba0e5 commit b589658

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

ext/TensorKitChainRulesCoreExt/factorizations.jl

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -56,8 +56,8 @@ end
5656
function ChainRulesCore.rrule(::typeof(TensorKit.eig!), t::AbstractTensorMap; kwargs...)
5757
D, V = eig(t; kwargs...)
5858

59-
function eig!_pullback((ΔD, ΔV))
60-
ΔD, ΔV = unthunk(ΔD), unthunk(ΔV)
59+
function eig!_pullback((_ΔD, _ΔV))
60+
ΔD, ΔV = unthunk(_ΔD), unthunk(_ΔV)
6161
Δt = similar(t)
6262
for (c, b) in blocks(Δt)
6363
Dc, Vc = block(D, c), block(V, c)
@@ -78,8 +78,8 @@ end
7878
function ChainRulesCore.rrule(::typeof(TensorKit.eigh!), t::AbstractTensorMap; kwargs...)
7979
D, V = eigh(t; kwargs...)
8080

81-
function eigh!_pullback((ΔD, ΔV))
82-
ΔD, ΔV = unthunk(ΔD), unthunk(ΔV)
81+
function eigh!_pullback((_ΔD, _ΔV))
82+
ΔD, ΔV = unthunk(_ΔD), unthunk(_ΔV)
8383
Δt = similar(t)
8484
for (c, b) in blocks(Δt)
8585
Dc, Vc = block(D, c), block(V, c)
@@ -116,8 +116,8 @@ function ChainRulesCore.rrule(::typeof(leftorth!), t::AbstractTensorMap; alg=QRp
116116
alg isa TensorKit.QR || alg isa TensorKit.QRpos ||
117117
error("only `alg=QR()` and `alg=QRpos()` are supported")
118118
Q, R = leftorth(t; alg)
119-
function leftorth!_pullback((ΔQ, ΔR))
120-
ΔQ, ΔR = unthunk(ΔQ), unthunk(ΔR)
119+
function leftorth!_pullback((_ΔQ, _ΔR))
120+
ΔQ, ΔR = unthunk(_ΔQ), unthunk(_ΔR)
121121
Δt = similar(t)
122122
for (c, b) in blocks(Δt)
123123
qr_pullback!(b, block(Q, c), block(R, c), block(ΔQ, c), block(ΔR, c))
@@ -132,8 +132,8 @@ function ChainRulesCore.rrule(::typeof(rightorth!), t::AbstractTensorMap; alg=LQ
132132
alg isa TensorKit.LQ || alg isa TensorKit.LQpos ||
133133
error("only `alg=LQ()` and `alg=LQpos()` are supported")
134134
L, Q = rightorth(t; alg)
135-
function rightorth!_pullback((ΔL, ΔQ))
136-
ΔL, ΔQ = unthunk(ΔL), unthunk(ΔQ)
135+
function rightorth!_pullback((_ΔL, _ΔQ))
136+
ΔL, ΔQ = unthunk(_ΔL), unthunk(_ΔQ)
137137
Δt = similar(t)
138138
for (c, b) in blocks(Δt)
139139
lq_pullback!(b, block(L, c), block(Q, c), block(ΔL, c), block(ΔQ, c))

0 commit comments

Comments
 (0)