some more fixes and tests

Author: Jutho

src/spaces/homspace.jl

@@ -355,7 +355,7 @@ end
 # TODO: is this something we want to cache?
 function diagonalblockstructure(W::HomSpace)
     ((numin(W) == numout(W) == 1) && domain(W) == codomain(W)) ||
-        throw(ArgumentError("Input space is not diagonal"))
+        throw(SpaceMismatch("Diagonal only support on V←V with a single space V"))
     structure = SectorDict{sectortype(W),UnitRange{Int}}() # range
     offset = 0
     dom = domain(W)[1]

src/tensors/adjoint.jl

@@ -27,8 +27,8 @@ block(t::AdjointTensorMap, s::Sector) = block(parent(t), s)'
 
 blocks(t::AdjointTensorMap) = BlockIterator(t, blocks(parent(t)))
 
-function blocktype(::Type{TT}) where {T,TT<:AdjointTensorMap{T}}
-    return Base.promote_op(adjoint, blocktype(T))
+function blocktype(::Type{AdjointTensorMap{T,S,N₁,N₂,TT}}) where {T,S,N₁,N₂,TT}
+    return Base.promote_op(adjoint, blocktype(TT))
 end
 
 function Base.iterate(iter::BlockIterator{<:AdjointTensorMap}, state...)

test/diagonal.jl

@@ -14,6 +14,15 @@ diagspacelist = ((ℂ^4)', ℂ[Z2Irrep](0 => 2, 1 => 3),
             @test space(t) == (V ← V)
             @test space(t') == (V ← V)
             @test dim(t) == dim(space(t))
+            # blocks
+            bs = @constinferred blocks(t)
+            (c, b1), state = @constinferred Nothing iterate(bs)
+            @test c == first(blocksectors(V ← V))
+            next = @constinferred Nothing iterate(bs, state)
+            b2 = @constinferred block(t, first(blocksectors(t)))
+            @test b1 == b2
+            @test eltype(bs) === typeof(b1) === TensorKit.blocktype(t)
+            # basic linear algebra
             @test isa(@constinferred(norm(t)), real(T))
             @test norm(t)^2 ≈ dot(t, t)
             α = rand(T)

test/tensors.jl

@@ -91,9 +91,14 @@ for V in spacelist
                 @test space(t) == (W ← one(W))
                 @test domain(t) == one(W)
                 @test typeof(t) == TensorMap{T,spacetype(t),5,0,Vector{T}}
-                bs = @inferred blocks(t)
-                b = @inferred block(t, first(blocksectors(t)))
-                @test eltype(bs) === typeof(b) === TensorKit.blocktype(t)
+                # blocks
+                bs = @constinferred blocks(t)
+                (c, b1), state = @constinferred Nothing iterate(bs)
+                @test c == first(blocksectors(W))
+                next = @constinferred Nothing iterate(bs, state)
+                b2 = @constinferred block(t, first(blocksectors(t)))
+                @test b1 == b2
+                @test eltype(bs) === typeof(b1) === TensorKit.blocktype(t)
             end
         end
         @timedtestset "Tensor Dict conversion" begin
@@ -146,6 +151,15 @@ for V in spacelist
                 @test dim(t) == dim(space(t))
                 @test codomain(t) == codomain(W)
                 @test domain(t) == domain(W)
+                # blocks for adjoint
+                bs = @constinferred blocks(t')
+                (c, b1), state = @constinferred Nothing iterate(bs)
+                @test c == first(blocksectors(W'))
+                next = @constinferred Nothing iterate(bs, state)
+                b2 = @constinferred block(t', first(blocksectors(t')))
+                @test b1 == b2
+                @test eltype(bs) === typeof(b1) === TensorKit.blocktype(t')
+                # linear algebra
                 @test isa(@constinferred(norm(t)), real(T))
                 @test norm(t)^2 ≈ dot(t, t)
                 α = rand(T)