some final small fixes

Author: lkdvos

src/tensors/factorizations/adjoint.jl

@@ -78,6 +78,12 @@ for f! in (:svd_full!, :svd_compact!, :svd_trunc!)
         $f!(adjoint(t), reverse(adjoint.(F)), _adjoint(alg))
         return F
     end
+
+    # disambiguate by prohibition
+    @eval function initialize_output(::typeof($f!), t::AdjointTensorMap,
+                                     alg::DiagonalAlgorithm)
+        throw(MethodError($f!, (t, alg)))
+    end
 end
 # avoid amgiguity
 function initialize_output(::typeof(svd_trunc!), t::AdjointTensorMap,

src/tensors/factorizations/matrixalgebrakit.jl

@@ -128,14 +128,6 @@ function check_input(::typeof(svd_compact!), t::AbstractTensorMap, USVᴴ,
     return nothing
 end
 
-function check_input(::typeof(svd_vals!), t::AbstractTensorMap, S::SectorDict,
-                     ::AbstractAlgorithm)
-    @check_scalar S t real
-    V_cod = V_dom = infimum(fuse(codomain(t)), fuse(domain(t)))
-    @check_space(S, V_cod ← V_dom)
-    return nothing
-end
-
 function check_input(::typeof(svd_vals!), t::AbstractTensorMap, D, ::AbstractAlgorithm)
     @check_scalar D t real
     @assert D isa DiagonalTensorMap

test/bugfixes.jl

@@ -47,7 +47,7 @@
     # https://github.com/quantumkithub/TensorKit.jl/issues/201
     @testset "Issue #201" begin
         function f(A::AbstractTensorMap)
-            U, S, V, = tsvd(A)
+            U, S, V, = svd_compact(A)
             return tr(S)
         end
         function f(A::AbstractMatrix)
@@ -60,7 +60,7 @@
         @test convert(Array, grad1) ≈ grad2
 
         function g(A::AbstractTensorMap)
-            U, S, V, = tsvd(A)
+            U, S, V, = svd_compact(A)
             return tr(U * V)
         end
         function g(A::AbstractMatrix)