some more review updates

Author: Jutho

src/factorizations/adjoint.jl

@@ -65,10 +65,14 @@ for (left_f, right_f) in zip(
         return reverse(adjoint.(MAK.initialize_output($left_f!, adjoint(t), _adjoint(alg))))
     end
 
-    @eval MAK.$left_f!(t::AdjointTensorMap, F, alg::AbstractAlgorithm) =
-        $right_f!(adjoint(t), reverse(adjoint.(F)), _adjoint(alg))
-    @eval MAK.$right_f!(t::AdjointTensorMap, F, alg::AbstractAlgorithm) =
-        $left_f!(adjoint(t), reverse(adjoint.(F)), _adjoint(alg))
+    @eval function MAK.$left_f!(t::AdjointTensorMap, F, alg::AbstractAlgorithm)
+        F′ = $right_f!(adjoint(t), reverse(adjoint.(F)), _adjoint(alg))
+        return reverse(adjoint.(F′))
+    end
+    @eval function MAK.$right_f!(t::AdjointTensorMap, F, alg::AbstractAlgorithm)
+        F′ = $left_f!(adjoint(t), reverse(adjoint.(F)), _adjoint(alg))
+        return reverse(adjoint.(F′))
+    end
 end
 
 # 3-arg functions
@@ -83,8 +87,8 @@ for f! in (:svd_full!, :svd_compact!, :svd_trunc!)
         return reverse(adjoint.(MAK.initialize_output($f!, adjoint(t), _adjoint(alg))))
     end
     @eval function MAK.$f!(t::AdjointTensorMap, F, alg::AbstractAlgorithm)
-        $f!(adjoint(t), reverse(adjoint.(F)), _adjoint(alg))
-        return F
+        F′ = $f!(adjoint(t), reverse(adjoint.(F)), _adjoint(alg))
+        return reverse(adjoint.(F′))
     end
 
     # disambiguate by prohibition

src/factorizations/pullbacks.jl

@@ -32,13 +32,19 @@ for pullback! in (:svd_pullback!, :eig_pullback!, :eigh_pullback!)
             Δt::AbstractTensorMap, t::AbstractTensorMap, F, ΔF, inds = _notrunc_ind(t);
             kwargs...
         )
-        for (c, ind) in inds
-            Δb = block(Δt, c)
-            b = block(t, c)
+        foreachblock(Δt, t) do c, (Δb, b)
             Fc = block.(F, Ref(c))
             ΔFc = block.(ΔF, Ref(c))
+            ind = inds[c]
             MAK.$pullback!(Δb, b, Fc, ΔFc, ind; kwargs...)
         end
+        # for (c, ind) in inds
+        #     Δb = block(Δt, c)
+        #     b = block(t, c)
+        #     Fc = block.(F, Ref(c))
+        #     ΔFc = block.(ΔF, Ref(c))
+        #     MAK.$pullback!(Δb, b, Fc, ΔFc, ind; kwargs...)
+        # end
         return Δt
     end
 end

src/factorizations/truncation.jl

@@ -21,7 +21,7 @@ Truncation strategy to keep the first values for each sector when sorted accordi
 such that the resulting vector space is no greater than `V`.
 """
 function truncspace(space::ElementarySpace; by = abs, rev::Bool = true)
-    isdual(space) && throw(ArgumentError("resulting vector space is never dual"))
+    isdual(space) && throw(ArgumentError("truncation space should not be dual"))
     return TruncationSpace(space, by, rev)
 end
 
@@ -37,15 +37,15 @@ function truncate_domain!(tdst::AbstractTensorMap, tsrc::AbstractTensorMap, inds
     for (c, b) in blocks(tdst)
         I = get(inds, c, nothing)
         @assert !isnothing(I)
-        copy!(b, @view(block(tsrc, c)[:, I]))
+        copy!(b, view(block(tsrc, c), :, I))
     end
     return tdst
 end
 function truncate_codomain!(tdst::AbstractTensorMap, tsrc::AbstractTensorMap, inds)
     for (c, b) in blocks(tdst)
         I = get(inds, c, nothing)
         @assert !isnothing(I)
-        copy!(b, @view(block(tsrc, c)[I, :]))
+        copy!(b, view(block(tsrc, c), I, :))
     end
     return tdst
 end